frei0r-plugins fails to build

[hobbsilla]

I'm running Macports 2.0.3 on Lion 10.7.2 on a Macbook Pro 5,5 trying to build kdenlive and it breaks at frei0r-plugins. Attached is the log file. I normally have an easier time spotting what the error is but I am not able to make sense of it.

[ryandesign (Ryan Carsten Schmidt)]

I see you're using clang. What if you use llvm-gcc-4.2 instead?

[ddennedy (Dan Dennedy)]

Also, it appears to be failing in opencv headers simply by including cv.h. It is not a big deal to drop the dependency on opencv, uninstall opencv, and let the configure script exclude the opencv-based plugins. Opencv is not a hard dependency, and those plugins are rarely used within kdenlive anyways.

[hobbsilla]

If I were to reinstall opencv do you think that might help as well?

[hobbsilla]

Also llvm-gcc-4.2 compiler didn't work. Currently waiting for apple-gcc42 to build and try using that. If that fails then I will try uninstall opencv afterwards. Thanks for the advice so far.

[ddennedy (Dan Dennedy)]

no, reinstalling opencv will not help.

[ryandesign (Ryan Carsten Schmidt)]

Replying to dan@…:

It is not a big deal to drop the dependency on opencv, uninstall opencv, and let the configure script exclude the opencv-based plugins. Opencv is not a hard dependency, and those plugins are rarely used within kdenlive anyways.

If you believe frei0r-plugins' opencv features are not useful to users, then I would support removing them. This would make frei0r-plugins much faster to install, since users would not have to install the large opencv port, and it would also let frei0r-plugins have a universal variant, since the only reason it currently does not is because opencv doesn't.

I've made these changes in the attached patch. Would you like me to commit it? Unfortunately I couldn't find a way to inform the configure script not to use opencv, so I had to patch it.

[ryandesign (Ryan Carsten Schmidt)]

patch to disable opencv and enable universal

[ddennedy (Dan Dennedy)]

Upstream is due for a new release. I think I should modify configure.ac to support explicit disabling of both gavl and opencv. Then, instead of dropping them entirely in this port, I want to add variants that include these dependencies. If you want to commit these patches to address this bug in the meantime, then I approve.

[hobbsilla]

Can I be directed to a link that explains how to use patches/.diff files?

[ryandesign (Ryan Carsten Schmidt)]

Replying to dan@…:

If you want to commit these patches to address this bug in the meantime, then I approve.

r87176

[ryandesign (Ryan Carsten Schmidt)]

Replying to hobbsilla@…:

Can I be directed to a link that explains how to use patches/.diff files?

​http://guide.macports.org/chunked/development.patches.html#development.patches.applying

[hobbsilla]

Much appreciated. For clarity, I manually apply this patch to frei0r-plugins, not opencv, correct?

[hobbsilla]

Replying to hobbsilla@…:

Much appreciated. For clarity, I manually apply this patch to frei0r-plugins, not opencv, correct?

I typed in the following (assuming it was frei0r-plugins) into my terminal got the following:

Paradise:~ elixir$ cd $(port dir frei0r-plugins)
Paradise:frei0r-plugins elixir$ patch -p0 < ~/Desktop/frei0r-plugins.diff 
patching file files/patch-configure.ac.diff
patch: **** Can't rename file /var/folders/80/28xh_mrj7k730ztvwk2p1hg80000gn/T//
poeN98JS to files/patch-configure.ac.diff : No such file or directory

[ryandesign (Ryan Carsten Schmidt)]

Replying to hobbsilla@…:

Much appreciated. For clarity, I manually apply this patch to frei0r-plugins, not opencv, correct?

If I had not already committed the fix, yes. But since I have already committed the fix, you just "sudo port selfupdate".

[hobbsilla]

Ah, much easier process haha. Thank you.

[ryandesign (Ryan Carsten Schmidt)]

Replying to hobbsilla@…:

Paradise:~ elixir$ cd $(port dir frei0r-plugins)
Paradise:frei0r-plugins elixir$ patch -p0 < ~/Desktop/frei0r-plugins.diff 
patching file files/patch-configure.ac.diff
patch: **** Can't rename file /var/folders/80/28xh_mrj7k730ztvwk2p1hg80000gn/T//
poeN98JS to files/patch-configure.ac.diff : No such file or directory

The default ports tree is not owned by you, so you need to be root to change it. Prefix the patch command with "sudo ".