Opened 12 years ago

Closed 12 years ago

#32168 closed enhancement (fixed)

wireshark 1.6.x: several requests

Reported by: jpo@… Owned by: ghosthound
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: Cc: opendarwin.org@…
Port: wireshark

Description

This ticket was created in order to make several requests/comments regarding/about the current wireshark port:

1) Wireshark 1.6.x should be build by default with the following options:

  • IPv6
    Pv6 networks are more common nowadays; and its numbers are expected to increase due to the recent exhaustion of the IPv4 address space; also, all recent MacOSX versions are IPv6 aware
  • libgcrypt
    Needed by the ipsec support; also needed by capinfos to calculate the pcap files hashes (MD5, SHA1, ...)
  • libsmi
    Enables wireshark to access SMI MIB module definitions (SNMP related)

2) The following variants are missing:

3) The bzip2 requirement appears to be bogus.

4) Wireshark builds with lua and c-ares support even if the variants aren't specified (lua and c-ares need to be installed in the building system)

Note: some of these requests had already been applied to the wireshark-devel Portfile (see #29968)

Regards, jpo

Attachments (1)

wireshark-Portfile.patch (9.1 KB) - added by jpo@… 12 years ago.
wireshark Portfile patch

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by jpo@…

Attachment: wireshark-Portfile.patch added

wireshark Portfile patch

comment:1 Changed 12 years ago by jpo@…

Patch changelog

  • adds the MacPorts modeline at the beginning of the Portfile
  • enforces the modeline (vim :retab)
  • changes the order of the lua and the libsmi variants
  • adds "default_variants +ipv6 +libgcrypt +libsmi" at the end of the file

/jpo

comment:2 Changed 12 years ago by raimue (Rainer Müller)

The +ipv6 variant was not enabled by default by request of the maintainer, see #17861.

comment:3 in reply to:  2 Changed 12 years ago by jpo@…

Replying to raimue@…:

The +ipv6 variant was not enabled by default by request of the maintainer, see #17861.

Do you know why it wasn't enabled by default? There is no reason given in the ticket you mention.

Shouldn't this decision be revisited? Three years ago we were talking about Wireshark 1.0 [1] and Mac OS X 10.4/10.5 (and there were IPv4 addresses still available [2]).

/jpo

[1] - https://trac.macports.org/browser/trunk/dports/net/wireshark/Portfile?rev=46908 [2] - https://en.wikipedia.org/wiki/IPv4_address_exhaustion

comment:4 Changed 12 years ago by mike-savory

I too would request making the IPv6 variant default now.

Also the latest build gives these warnings wireshark-1.6.5.tar.bz2

--->  Staging wireshark into destroot
Warning: violation by /opt/local/homeplug.py.sample
Warning: violation by /opt/local/register-dissector.py
Warning: violation by /opt/local/wspy_dissector.py
Warning: violation by /opt/local/wspy_libws.py
Warning: wireshark violates the layout of the ports-filesystems!
Warning: Please fix or indicate this misbehavior (if it is intended), it will be an error in future releases!

comment:5 Changed 12 years ago by ghosthound

Owner: changed from macports-tickets@… to ricci@…
Status: newassigned

+python mtree violation (see #31757) and -lua picking up installed lua support fixed in r89676. Note that wireshark defaults to building with c-ares.

In the future, please separate different issues into different tickets, there are a number of disparate issues in this ticket that should be tracked separately, not together.

comment:6 Changed 12 years ago by jmroot (Joshua Root)

The whitespace changes in the patch make it very difficult to see what the actual functional changes are.

comment:7 Changed 12 years ago by ghosthound

Resolution: fixed
Status: assignedclosed

resolved in r94583

Note: See TracTickets for help on using tickets.