Opened 5 years ago

Closed 5 years ago

#32246 closed defect (fixed)

fossil needs readline dependency

Reported by: ryandesign (Ryan Schmidt) Owned by: ci42
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc:
Port: fossil

Description

fossil links with readline but does not declare a dependency on it.

$ otool -L /opt/local/bin/fossil
/opt/local/bin/fossil:
	/opt/local/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.5)
	/opt/local/lib/libssl.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/opt/local/lib/libcrypto.1.0.0.dylib (compatibility version 1.0.0, current version 1.0.0)
	/opt/local/lib/libreadline.6.2.dylib (compatibility version 6.0.0, current version 6.2.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 125.2.11)
$ port rdeps fossil
The following ports are dependencies of fossil @1.20_0+universal:
  tcl
  zlib
  openssl

Attachments (1)

fossil-readline.diff (563 bytes) - added by ryandesign (Ryan Schmidt) 5 years ago.
proposed patch

Download all attachments as: .zip

Change History (2)

Changed 5 years ago by ryandesign (Ryan Schmidt)

proposed patch

comment:1 in reply to: ↑ description Changed 5 years ago by ci42

  • Resolution set to fixed
  • Status changed from new to closed

Replying to ryandesign@…:

fossil links with readline but does not declare a dependency on it.

Thanks for your patch. I made readline support an optional variant in r87561. It is only used in the 'fossil sqlite3' command which starts an sqlite command-line shell on the repository database. This is potential dangerous command which could corrupt the repository if not used carefully. It is mainly for debugging purposes, ommitting readline support for the sqllite command-line shell should not affect normal users. Additionally, if not linked against readline, it allows fossil to be binary distributable, avoiding the openssl/gpl conflict.

Note: See TracTickets for help on using tickets.