Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#32793 closed enhancement (fixed)

poppler: Drop dependency on gtk2

Reported by: raimue (Rainer Müller) Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: haspatch Cc: singingwolfboy@…, drkp (Dan Ports), ryandesign (Ryan Carsten Schmidt)
Port: poppler

Description

The poppler port does not really need to depend on gtk2. There is only one binary linked against libgtk, which is a demo and can be removed without loosing functionality (actually, it always resulted in a "Segmentation fault" in my tests):

$ port contents poppler |grep -E '/opt/local/(bin|lib/.*\.dylib)' |xargs otool -L |grep -B13 gtk
/opt/local/bin/poppler-glib-demo:
...
	/opt/local/lib/libgtk-x11-2.0.0.dylib (compatibility version 2401.0.0, current version 2401.8.0)

To be honest, this change does not cut the dependency tree more than gtk2 itself. But as gtk2 is a big port, I think the reduction is significant enough to vindicate this change.

Attachments (1)

poppler-no_gtk.diff (878 bytes) - added by raimue (Rainer Müller) 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by raimue (Rainer Müller)

Attachment: poppler-no_gtk.diff added

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: singingwolfboy@… added
Keywords: haspatch added
Owner: changed from singingwolfboy@… to devans@…

Isn't this Dave Evans' port?

comment:2 Changed 12 years ago by drkp (Dan Ports)

Cc: dports@… added

I haven't tried the patch at all, but it'd be great to drop this dependency if possible -- this makes a number of ports (e.g. texlive) depend needlessly on gtk, and it'd be nice if that weren't the case.

comment:3 Changed 12 years ago by drkp (Dan Ports)

Resolution: fixed
Status: newclosed

This seems to work fine for me, and it's great to reduce the number of dependencies, so I committed in in r90937.

comment:4 Changed 12 years ago by drkp (Dan Ports)

Actually, this helps more than I expected. It removes a total of 35 dependencies from the texlive dependency tree, including things like pango, cairo, gdk-pixbuf2, gtk-doc and friends, and a dozen or so xorg libraries. Not bad.

comment:5 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added

This also has the effect of removing the indirect glib2 dependency, which was needed to build the poppler-glib library, so glib2 has to go back in. See #32924 in which this and several other dependencies will be added.

Note: See TracTickets for help on using tickets.