Opened 8 years ago

Closed 8 years ago

#33410 closed defect (fixed)

samtools @0.1.17 fix - respect build_arch

Reported by: mg13@… Owned by: haroldpimentel@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: samtools

Description

This patch ensures the correct macports-calculated CFLAGS propagate to the make, thus allowing correct building when build_arch &/or macosx_deployment_target are set.

It's a bit of a hack but seems to work - there may be a more 'approved' way of doing this.

Attachments (2)

Portfile-samtools.diff (1.4 KB) - added by mg13@… 8 years ago.
Patch for samtools Portfile
patch-Makefile.diff (445 bytes) - added by mg13@… 8 years ago.
samtools Makefile patch

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by ryandesign (Ryan Schmidt)

I agree, that does look very hacky, and I would look for a different way to do it that is more similar to the way we've done it in other ports. At the same time, adding support for a universal variant would be a good idea. The [get_canonical_archflags] procedure will likely be useful.

Changed 8 years ago by mg13@…

Attachment: Portfile-samtools.diff added

Patch for samtools Portfile

Changed 8 years ago by mg13@…

Attachment: patch-Makefile.diff added

samtools Makefile patch

comment:2 in reply to:  1 Changed 8 years ago by mg13@…

Replying to ryandesign@…:

I agree, that does look very hacky, and I would look for a different way to do it that is more similar to the way we've done it in other ports. At the same time, adding support for a universal variant would be a good idea. The [get_canonical_archflags] procedure will likely be useful.

Okay, I've just uploaded a new version which uses [get_canonical_archflags]. I'm afraid I haven't got time to investigate a universal variant right now.

This now also updates the samtools version to 0.1.18.

Michael

comment:3 Changed 8 years ago by jmroot (Joshua Root)

Cc: haroldpimentel@… removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to haroldpimentel@…

comment:4 Changed 8 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.