Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#33423 closed update (fixed)

Updated swi-prolog portfile for version 6.0.1

Reported by: pmoura (Paulo Moura) Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version: 2.0.4
Keywords: haspatch maintainer Cc:
Port: swi-prolog

Description

Updated swi-prolog portfile for version 6.0.1.

Attachments (1)

Portfile-swi-prolog.diff (1.4 KB) - added by pmoura (Paulo Moura) 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by neverpanic (Clemens Lang)

  • Owner changed from macports-tickets@… to cal@…
  • Status changed from new to assigned

Can you elaborate on why PKG_CONFIG_PATH=/usr/X11R6/lib/pkgconfig is needed? We usually don't link against system X11 libs in MacPorts, but rather depend on and link against the appropriate xorg-* port. See wiki:FAQ#ownlibs.

comment:2 Changed 5 years ago by pmoura (Paulo Moura)

That line is taken from the SWI-Prolog developer instructions for Mac OS X. I'm not familiar with PKG_CONFIG. Tested the patch before submitting. Everything seems fine. Your suggested alternative would be?

Changed 5 years ago by pmoura (Paulo Moura)

comment:3 Changed 5 years ago by pmoura (Paulo Moura)

Talked with the SWI-Prolog developer today. It seems to be safe to drop /usr/X11R6/lib/pkgconfig from the definition of the PKG_CONFIG_PATH environment variable. Already replaced the patch applying this change.

comment:4 Changed 5 years ago by neverpanic (Clemens Lang)

  • Resolution set to fixed
  • Status changed from assigned to closed

I've commited this for now in r90316.

I think I have a few points where the portfile can be improved (e.g. building with clang might work), but I'll just put it on my todo list and open a ticket as soon as I have a tested patch.

comment:5 Changed 5 years ago by pmoura (Paulo Moura)

Building with clang does work but it kills performance. Apparently, due to poor support for GCC threaded code. The same thing happens with e.g. YAP, another Prolog compiler. The best performance in both cases is achieved using a recent version of GCC.

Btw, can you also take care of committing the update to the "swi-prolog-devel" port? Thanks.

Note: See TracTickets for help on using tickets.