Opened 9 years ago

Closed 9 years ago

#33849 closed update (duplicate)

py26-openbabel: update to 2.3.0

Reported by: atenderholt@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.0.4
Keywords: haspatch Cc: mlund@…, ryandesign (Ryan Schmidt)
Port: py26-openbabel

Description

Update port to match version of newest OpenBabel (2.3.0) in MacPorts.

Based on the py27-openbabel Portfile (ticket #33848). Note that I have not tested this with Python 2.6, but the Python 2.7 version works fine.

Attachments (1)

Portfile (1.2 KB) - added by atenderholt@… 9 years ago.
Portfile for py26-openbabel

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by atenderholt@…

Attachment: Portfile added

Portfile for py26-openbabel

comment:1 Changed 9 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added
Summary: update port: py26-openbabelpy26-openbabel: update to 2.3.0

In the future, for existing ports, please supply a unified diff of your changes instead of a complete new port; that makes it easier to review your proposed changes.

-I${prefix}/include/openbabel-2.0 does not belong in build.target. It might belong in build.args but I'm still uncomfortable about hardcoding that value, specifically the 2.0 version number which seems likely to change in future versions of openbabel. Is there a way to ask openbabel for this value -- maybe via a config script or pkg-config?

comment:2 in reply to:  1 Changed 9 years ago by atenderholt@…

Replying to ryandesign@…:

In the future, for existing ports, please supply a unified diff of your changes instead of a complete new port; that makes it easier to review your proposed changes.

Thanks for the tip, I completely forgot that a diff is more appropriate.

-I${prefix}/include/openbabel-2.0 does not belong in build.target. It might belong in build.args but I'm still uncomfortable about hardcoding that value, specifically the 2.0 version number which seems likely to change in future versions of openbabel. Is there a way to ask openbabel for this value -- maybe via a config script or pkg-config?

I'm not sure why, but pkg-config expects openbabel-2.0 to be passed to it instead of openbabel or openbabel-${version}. Nothing in the openbabel Portfile suggests why this is the case. What is the best way to proceed?

comment:3 Changed 9 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added
Resolution: duplicate
Status: newclosed

A new unified py-openbabel port has been submitted in #33848 which supersedes this ticket.

Note: See TracTickets for help on using tickets.