Opened 9 years ago

Closed 8 years ago

#33887 closed enhancement (fixed)

go: update to version 1.0.2

Reported by: drkp (Dan Ports) Owned by: singingwolfboy@…
Priority: Normal Milestone:
Component: ports Version: 2.0.4
Keywords: haspatch Cc: kbrint@…, slewsys (Andrew L. Moore), mkb-prime@…
Port: go

Description

Go version 1 has been released: http://blog.golang.org/2012/03/go-version-1-is-released.html

The port should probably be updated.

Attachments (3)

go1.patch (3.6 KB) - added by kbrint@… 8 years ago.
Update go port to version 1.0.2
Portfile.diff (4.6 KB) - added by slewsys (Andrew L. Moore) 8 years ago.
Alternative Portfile update
Portfile.2.diff (4.8 KB) - added by slewsys (Andrew L. Moore) 8 years ago.
Configure version-less install by modifying only GOSRCDIR

Download all attachments as: .zip

Change History (11)

Changed 8 years ago by kbrint@…

Attachment: go1.patch added

Update go port to version 1.0.2

comment:1 Changed 8 years ago by kbrint@…

Cc: kbrint@… added

Cc Me!

comment:3 Changed 8 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added

comment:4 Changed 8 years ago by ryandesign (Ryan Schmidt)

Cc: slewsys@… added
Summary: go: update to version 1go: update to version 1.0.2

Has duplicate #35274 which contains another update proposal which may be different. Please consolidate the two proposals if necessary.

Changed 8 years ago by slewsys (Andrew L. Moore)

Attachment: Portfile.diff added

Alternative Portfile update

comment:5 in reply to:  4 Changed 8 years ago by slewsys (Andrew L. Moore)

Replying to ryandesign@…:

Has duplicate #35274 which contains another update proposal which may be different. Please consolidate the two proposals if necessary.

I missed this ticket. Our patches our similar, but attached mine above for it adds:

  • PATH to test.env (allowing `port -d test' prior to install),
  • doc to share/doc,
  • misc to share/go.

The only other difference is that I set GOROOT_FINAL to ${prefix}/lib/go${version}, in the spirit of lib/perl or lib/ruby.

comment:6 Changed 8 years ago by kbrint@…

I favor slewsys' patch with one exception: I think we should leave GOROOT_FINAL versionless: /usr/local/lib/go

Go has its own package management, and it's likely that users will install some packages with "go get" instead of the ports system. If we version the GOROOT_FINAL directory, those packages disappear when the port is upgraded. If we leave it alone, they will continue to work.

Thoughts?

Changed 8 years ago by slewsys (Andrew L. Moore)

Attachment: Portfile.2.diff added

Configure version-less install by modifying only GOSRCDIR

comment:7 in reply to:  6 Changed 8 years ago by slewsys (Andrew L. Moore)

Go has its own package management, and it's likely that users will install some packages with "go get" instead of the ports system. If we version the GOROOT_FINAL directory, those packages disappear when the port is upgraded. If we leave it alone, they will continue to work.

If GOROOT is versioned, then libs and binaries (under OLD_GOROOT/pkg and OLD_GOROOT/bin) will be unavailable on upgrade, but the source packages (under (OLD_GOROOT/src/pkg) are still available by setting the GOPATH environment variable, e.g.:

export GOPATH="$GOROOT:$OLD_GOROOT"

The Go language may be stable, but does that exclude the possibility of incompatibilities between compilers? I'm not qualified to answer that. Nontheless, per kbrint's suggestion, I've attached Portfile2.diff to the ticket. The version can be removed by changing:

set GOSRCDIR lib/${name}/${version}

to

set GOSRCDIR lib/${name}

comment:8 Changed 8 years ago by ryandesign (Ryan Schmidt)

Cc: mkb-prime@… added

Has duplicate #36181.

comment:9 Changed 8 years ago by singingwolfboy@…

Resolution: fixed
Status: newclosed

go port updated in r97891. Also, I've released maintainership of this port (r97892) so if someone else would like to pick it up, please do so.

Note: See TracTickets for help on using tickets.