Opened 8 years ago

Closed 8 years ago

#33957 closed defect (fixed)

Webkit-gtk 1.2.7 error ‘struct’ tag used in naming ‘union _GMutex’

Reported by: jovo@… Owned by: myschizobuddy@…
Priority: Normal Milestone:
Component: ports Version: 2.0.4
Keywords: Cc: dbevans (David B. Evans), vlsd (Vlad), macports@…, elelay (Eric Le Lay), jeremyhu (Jeremy Huddleston Sequoia)
Port: webkit-gtk

Description

Webkit-gtk does not install due to a compilation error in GOwnPtr.h (?)

:info:build /opt/local/bin/msgmerge --update pt.po webkit.pot
:info:build ............................ done.
:info:build /opt/local/bin/gmkdir -p ./.deps/DerivedSources
:info:build   CXX    WebCore/plugins/gtk/libwebkit_1_0_la-PluginPackageGtk.lo
:info:build In file included from WebCore/plugins/gtk/PluginPackageGtk.cpp:36:
:info:build ./JavaScriptCore/wtf/gobject/GOwnPtr.h:34: error: ‘struct’ tag used in naming ‘union _GMutex’
:info:build make[1]: *** [WebCore/plugins/gtk/libwebkit_1_0_la-PluginPackageGtk.lo] Error 1
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/webkit-gtk/work/webkit-1.2.7'
:info:build make: *** [all] Error 2
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/webkit-gtk/work/webkit-1.2.7'
:info:build shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/webkit-gtk/work/webkit-1.2.7" && /usr/bin/make -w all " returned error 2
:error:build Target org.macports.build returned: shell command failed (see log for details)
:debug:build Backtrace: shell command failed (see log for details)
    while executing
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"
:info:build Warning: the following items did not execute (for webkit-gtk): org.macports.activate org.macports.build org.macports.destroot org.macports.install
:notice:build Log for webkit-gtk is at: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/webkit-gtk/main.log

This on Macbook Pro with OS X 1.0.6.8 and Macports 2.0.4

Attachments (2)

main.log (1.9 MB) - added by vlsd (Vlad) 8 years ago.
The error log file generated when trying to build webkit-gtk
patch-JavaScriptCore-wtf-gobject-GOwnPtr.h.diff (1023 bytes) - added by elelay (Eric Le Lay) 8 years ago.
include glib.h directly

Download all attachments as: .zip

Change History (15)

comment:1 Changed 8 years ago by jovo@…

This looks similar to Bugzilla defect https://bugs.webkit.org/show_bug.cgi?id=72085 but I have no idea how to fix this in MP.

comment:2 Changed 8 years ago by mf2k (Frank Schima)

Cc: devans@… added; myschizobuddy@… removed
Owner: changed from macports-tickets@… to myschizobuddy@…
Priority: HighNormal

comment:3 Changed 8 years ago by mf2k (Frank Schima)

Please clean and attach the main.log.

comment:4 Changed 8 years ago by vlsd (Vlad)

Cc: vloodo@… added

Cc Me!

comment:5 in reply to:  3 ; Changed 8 years ago by vlsd (Vlad)

I am having the same issue (I think). What exactly do you mean by "cleaning" main.log?

Replying to macsforever2000@…:

Please clean and attach the main.log.

comment:6 in reply to:  5 Changed 8 years ago by vlsd (Vlad)

Never mind, I just realized you meant clean the build files first. Silly me.

Replying to vloodo@…:

I am having the same issue (I think). What exactly do you mean by "cleaning" main.log?

Replying to macsforever2000@…:

Please clean and attach the main.log.

Changed 8 years ago by vlsd (Vlad)

Attachment: main.log added

The error log file generated when trying to build webkit-gtk

comment:7 Changed 8 years ago by elelay (Eric Le Lay)

comment:8 Changed 8 years ago by vlsd (Vlad)

I can confirm that changing line 34 of GOwnPtr.h this way:

-typedef struct _GMutex GMutex;
+typedef union  _GMutex GMutex;

allows me to compile.

Changed 8 years ago by elelay (Eric Le Lay)

include glib.h directly

comment:9 Changed 8 years ago by elelay (Eric Le Lay)

or, to be compatible with older versions of glib2, #include <glib.h> and remove the custom definitions (see attached patch).

comment:10 Changed 8 years ago by macports@…

Cc: macports@… added

Cc Me!

comment:11 Changed 8 years ago by elelay (Eric Le Lay)

Cc: elelay@… added

Cc Me!

comment:12 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Cc: jeremyhu@… added

Cc Me!

comment:13 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.