Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#34086 closed defect (fixed)

webkit-gtk @1.6.3 - Configure error - build failure

Reported by: macports1@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.0.4
Keywords: webkit Cc: dbevans (David B. Evans), jeremyhu (Jeremy Huddleston Sequoia), ryandesign (Ryan Schmidt)
Port: webkit-gtk

Description

I'm building webkit wih +quartz and it is complaining about the missing package xrender.

Attachments (5)

config.log (67.6 KB) - added by macports1@… 8 years ago.
main.log (25.4 KB) - added by macports1@… 8 years ago.
xrender-check.patch (427 bytes) - added by chief1983@… 8 years ago.
XRender check fix in the Configure in the MacPorts tar of the source
webkit-portfile.patch (541 bytes) - added by chief1983@… 8 years ago.
Patch to portfile to use xrender check patch
after-xrender-patch.log (414.4 KB) - added by chief1983@… 8 years ago.
Log of build after applying my patch

Download all attachments as: .zip

Change History (14)

Changed 8 years ago by macports1@…

Attachment: config.log added

Changed 8 years ago by macports1@…

Attachment: main.log added

comment:1 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Looks like a bug in configure.ac ... they add a check for xrender even if quartz is chosen:

# check for XRender under Linux/Unix. Some linkers require explicit
# linkage (like GNU Gold), so we cannot rely on GTK+ pulling XRender
if test "$os_win32" = "no"; then
   PKG_CHECK_MODULES([XRENDER], [xrender])
   AC_SUBST([XRENDER_CFLAGS])
   AC_SUBST([XRENDER_LIBS])
fi

comment:2 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Changed 8 years ago by chief1983@…

Attachment: xrender-check.patch added

XRender check fix in the Configure in the MacPorts tar of the source

Changed 8 years ago by chief1983@…

Attachment: webkit-portfile.patch added

Patch to portfile to use xrender check patch

comment:3 Changed 8 years ago by chief1983@…

I made a patch to the port to work around this for the time being, but it gets stopped on a build error now. Attaching the log too.

Changed 8 years ago by chief1983@…

Attachment: after-xrender-patch.log added

Log of build after applying my patch

comment:4 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Cc: ryandesign@… added

Thanks for the patch. I got sidetracked with other stuff.

The error you're getting is:

error: pango/pangocairo.h: No such file or directory

That makes me think it's missing a dependency on the pango port. Do you have pango installed? gtk2 depends on pango, so that's a bid odd. FWIW:

$ port contents pango | grep cairo
  /opt/local/include/pango-1.0/pango/pangocairo.h
  /opt/local/lib/libpangocairo-1.0.0.dylib
  /opt/local/lib/libpangocairo-1.0.a
  /opt/local/lib/libpangocairo-1.0.dylib
  /opt/local/lib/libpangocairo-1.0.la
  /opt/local/lib/pkgconfig/pangocairo.pc

But that is of course with the +x11 pango variant.

Ryan knows more about pango than I do, so looping him in.

comment:5 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

r92131 has the xrender-check patch.

Regarding the pango bits, I see "-I./Source/WebCore/platform/graphics/pango" in your CFLAGS, but I don't see -I${prefix}/include/pango-1.0 like I would expect.

comment:6 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

In #24622 (which added the variant), they set the font backend to be pango instead of freetype for the +quartz variant. I don't see why.

What happens if you delete the "--with-font-backend=pango" from your configure.args (make sure you have freetype installed)

comment:7 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Also, I see the same failure with +x11 if I change the font backend to pango.

https://bugs.webkit.org/show_bug.cgi?id=77832

comment:8 Changed 8 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: newclosed

I think r92135 should fix this now. Please reopen or file a new bug if there are additional issues.

comment:9 Changed 8 years ago by ryandesign (Ryan Schmidt)

Apparently still a problem; see #34134.

Note: See TracTickets for help on using tickets.