Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#34210 closed update (fixed)

pianobar: update to 2012.04.24

Reported by: cowboycodur@… Owned by: aguynamedryan+pianobar@…
Priority: Normal Milestone:
Component: ports Version: 2.0.4
Keywords: haspatch Cc: ryandesign (Ryan Carsten Schmidt)
Port: pianobar

Description (last modified by ryandesign (Ryan Carsten Schmidt))

Error:

"Welcome to pianobar (2012.01.10)! Press ? for a list of commands.
(i) Login... Error: Protocol incompatible. Please upgrade libpiano."
New release available on github

+Release 2012.04.24
+
+- Fix format string crash
+- Fix sync response parser
+- Fix possible stdin close on error
+- Fix undefined behavior (mutex unlock)
+- Use TLS for every request with new setting force_tls
+- New error codes EXCESSIVE_ACTIVITY and DAILY_SKIP_LIMIT_REACHED
+- Autoselect last remaining item of filtered list, disable with autoselect = 0
+- Warn if control fifo is not a fifo
+- Code cleanup

Attachments (3)

patch-main.diff (1.2 KB) - added by aguynamedryan+macports@… 12 years ago.
Patch to main as part of fix
patch-piano.diff (756 bytes) - added by aguynamedryan+macports@… 12 years ago.
Patch for piano.c as part of fix
pianobar-t34210.diff (1.2 KB) - added by aguynamedryan+macports@… 12 years ago.
Patch to Portfile as part of fix

Download all attachments as: .zip

Change History (12)

comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Owner: changed from macports-tickets@… to aguynamedryan+pianobar@…
Summary: pianobar updatepianobar: update to 2012.04.24

comment:2 Changed 12 years ago by aguynamedryan+macports@…

Thanks for the heads up!

Sadly, the 2012.04.24 release doesn't fix the error. The author cut the 2012.04.24 release just before the protocol error cropped up.

I'm watching this issue: https://github.com/PromyLOPh/pianobar/issues/236 and waiting for the author to release a fix before I bother updating the Portfile.

comment:3 in reply to:  2 Changed 12 years ago by cowboycodur@…

Replying to aguynamedryan+macports@…:

Thanks for the heads up!

Sadly, the 2012.04.24 release doesn't fix the error. The author cut the 2012.04.24 release just before the protocol error cropped up.

I'm watching this issue: https://github.com/PromyLOPh/pianobar/issues/236 and waiting for the author to release a fix before I bother updating the Portfile.

Looks like they patched it,

comment:4 Changed 12 years ago by aguynamedryan+macports@…

Thanks for keeping me posted!

Unless someone else wants to make the necessary changes to the Portfile to apply the patch, I'm going to wait until the author at least commits the patch to the repo and pull down the commit that fixes the issue.

comment:5 Changed 12 years ago by cowboycodur@…

Doesn't look like he is going to commit the patch. I did a git clone and applied the patch and then apply the changes from the current makefile diff. What else needs to be done to compile from source. I am getting alot of compilation errors.

Changed 12 years ago by aguynamedryan+macports@…

Attachment: patch-main.diff added

Patch to main as part of fix

Changed 12 years ago by aguynamedryan+macports@…

Attachment: patch-piano.diff added

Patch for piano.c as part of fix

Changed 12 years ago by aguynamedryan+macports@…

Attachment: pianobar-t34210.diff added

Patch to Portfile as part of fix

comment:6 in reply to:  5 ; Changed 12 years ago by aguynamedryan+macports@…

Replying to cowboycodur@…:

I agree that the author probably won't commit the patch, so I've attached a patches for the Portfile to use the 2012.04.24 release along with the patch. I have compiled/run pianobar with these new patches and the login error appears to be fixed.

comment:7 in reply to:  6 Changed 12 years ago by cowboycodur@…

Replying to aguynamedryan+macports@…:

Replying to cowboycodur@…:

I agree that the author probably won't commit the patch, so I've attached a patches for the Portfile to use the 2012.04.24 release along with the patch. I have compiled/run pianobar with these new patches and the login error appears to be fixed.

Patch files work great, Thanks!

comment:8 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: haspatch added
Resolution: fixed
Status: newclosed

Committed in r92390, but I changed the names of the patchfiles to match usual naming conventions, and I put them in the global part of the portfile, not in the platform darwin block, since unlike the existing Makefile patch, these patches don't seem to be OS X-specific.

comment:9 in reply to:  8 Changed 12 years ago by aguynamedryan+macports@…

Replying to ryandesign@…:

Awesome. Thanks for cleaning up my mess!

Note: See TracTickets for help on using tickets.