Opened 19 years ago

Closed 19 years ago

#3425 closed defect (wontfix)

patch to add new fetch types

Reported by: erickt@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: base Version: 1.0
Keywords: Cc:
Port:

Description

Hello All,

I added a couple new types of fetch mechanisms to darwinports, as you'll find in the attached patch. I've added 3 new mechanisms: rsync, svn, and a custom command. Because darwinports internally uses rsync, I modified the configure.ac to find rsync on the path. For svn, since it is not installed by default, I look it up at runtime using env. To support env, I also added it to be found in configure.ac. Finally, I added a custom command, so someone can manually specify a fetch command by specifying the cmd and args. I've tested the rsync and the svn functionality, and both work (I'll attach my prototype portfile's that have these built in). While I haven't tested the custom command, it's almost exactly the same as the rsync code, so hopefully it won't be a problem.

The only tricky thing about this patch is that if you want to use svn, you have to have svn installed. Is it possible to have a fetch automatically append a svn dependancy? That's really the only thing missing about this patch, but I don't know enought of the internals in order to figure it out.

Any chance that this could be integrated into the system? Thanks!

-e

Attachments (2)

darwinports-diff (4.5 KB) - added by erickt@… 19 years ago.
a couple diffs to add the extra fetch functionality
testing.tgz (2.2 KB) - added by erickt@… 19 years ago.
portfiles demonstrating added functionality

Download all attachments as: .zip

Change History (5)

Changed 19 years ago by erickt@…

Attachment: darwinports-diff added

a couple diffs to add the extra fetch functionality

Changed 19 years ago by erickt@…

Attachment: testing.tgz added

portfiles demonstrating added functionality

comment:1 Changed 19 years ago by erickt@…

so, any comments?

comment:2 Changed 19 years ago by pguyot (Paul Guyot)

You can have a custom fetch procedure in Portfiles with:

fetch { }

Some ports already do that.

This makes the custom fetch type useless.

Considering rsync and svn, the official position is to avoid any non reproduceable download as much as possible. This is why cvs isn't well regarded. Instead, port maintainers are supposed to create tarball and put them in their opendarwin ~.

Indeed we lack dependencies to be satisfied before fetch and/or extract targets are executed.

comment:3 Changed 19 years ago by toby@…

Resolution: wontfix
Status: newclosed

Marking WONTFIX; as Paul says, we don't like CVS fetch as it is. No reason to perpetuate the madness!

Note: See TracTickets for help on using tickets.