Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#34395 closed defect (fixed)

cloog +universal won't install into destroot

Reported by: watsodw Owned by: adfernandes (Andrew Fernandes)
Priority: Normal Milestone:
Component: ports Version: 2.0.4
Keywords: Cc: stephen@…
Port: cloog

Description

Installing cloog 0.16.3 +universal variant won't install into destroot, log says cloog-isl.pc file's i386 and x86_64 variants cannot be merged.

Attachments (7)

main.log (267.7 KB) - added by watsodw 12 years ago.
cloog-isl.pc (502 bytes) - added by stephen@… 12 years ago.
Portfile.patch (911 bytes) - added by adfernandes (Andrew Fernandes) 12 years ago.
Portfile (2.0 KB) - added by adfernandes (Andrew Fernandes) 12 years ago.
Portfile.2 (2.2 KB) - added by adfernandes (Andrew Fernandes) 12 years ago.
work.zip (8.8 MB) - added by stephen@… 12 years ago.
patch-cloog-Portfile.diff (1.6 KB) - added by pixilla (Bradley Giesbrecht) 12 years ago.
Working Portfile patch

Change History (29)

Changed 12 years ago by watsodw

Attachment: main.log added

comment:1 Changed 12 years ago by adfernandes (Andrew Fernandes)

Grr... at least it builds! :-)

Could you please try the attached patch and see if it builds? This is the same hack from ppl. Thanks!

comment:2 Changed 12 years ago by watsodw

No good. Still won't install. Same error.

comment:3 Changed 12 years ago by adfernandes (Andrew Fernandes)

Hmm.

Can you please attach the files `work/destroot*/opt/macports/lib/pkgconfig/cloog-isl.pc'?

Maybe a quick hack on the *.pc files is the trick...

comment:4 Changed 12 years ago by stephen@…

I have the same problem on 10.7.4 + Xcode 4.3.2. Will attach my copy of .pc file.

Changed 12 years ago by stephen@…

Attachment: cloog-isl.pc added

comment:5 Changed 12 years ago by adfernandes (Andrew Fernandes)

Got it. The -arch flag was incorrectly being set in the *.pc files for pkgconfig .

Can you try the attached Portfile (port OR updated patch) and see if this gets rid of the problem?

Changed 12 years ago by adfernandes (Andrew Fernandes)

Attachment: Portfile.patch added

Changed 12 years ago by adfernandes (Andrew Fernandes)

Attachment: Portfile added

comment:6 Changed 12 years ago by stephen@…

Cc: stephen@… added

Cc Me!

comment:7 Changed 12 years ago by stephen@…

That doesn't work. Still getting the same merge failure.

comment:8 Changed 12 years ago by stephen@…

the post-destroot part doesn't seem to be running, at least not before the error occurs. Also, isn't ${destroot} not enough to specify the actual dest root? There are 4 of them in my work dir (destroot-i386, destroot-x86_64, etc.)

comment:9 Changed 12 years ago by adfernandes (Andrew Fernandes)

Grr. I wish I had my own universal to work with. Okay; I re-did the bit to remove the -arch flags from the *.pc files. Can you try the updated attached Portfile? Thanks!

Changed 12 years ago by adfernandes (Andrew Fernandes)

Attachment: Portfile.2 added

comment:10 Changed 12 years ago by pixilla (Bradley Giesbrecht)

Doesn't the muniversal portgroup have some issue with merging more then two archs? Seems I have seen several ports with workarounds for this.

See the dbus port.

comment:11 Changed 12 years ago by adfernandes (Andrew Fernandes)

Good point, pixilla, but I don't think that's the problem here. The *.pc files are erroneously including -arch flags. After removing them, all the *.pc files should be identical, so I'm hoping that there will not be any "multi-way" merge issues.

comment:12 Changed 12 years ago by stephen@…

That new profile doesn't work. Here's the message:

Error: Target org.macports.build returned: no files matched glob patterns "*.pc */*.pc"

Let me attach the work folder post-build (sans object files) so you have the files to work with.

Changed 12 years ago by stephen@…

Attachment: work.zip added

Changed 12 years ago by pixilla (Bradley Giesbrecht)

Attachment: patch-cloog-Portfile.diff added

Working Portfile patch

comment:13 Changed 12 years ago by mf2k (Frank Schima)

Cc: openmaintainer@… removed

comment:14 Changed 12 years ago by stephen@…

I am happy to report that the latest patch fixed the problem and it now builds and installs properly. Thanks.

comment:15 Changed 12 years ago by watsodw

Works for me too!

comment:16 Changed 12 years ago by pixilla (Bradley Giesbrecht)

Cc: adfernandes@… removed
Owner: changed from macports-tickets@… to adfernandes@…

comment:17 Changed 12 years ago by pixilla (Bradley Giesbrecht)

stephen and david, are you referring to patch-cloog-Portfile.diff?

comment:18 in reply to:  17 Changed 12 years ago by stephen@…

Replying to pixilla@…:

stephen and david, are you referring to patch-cloog-Portfile.diff?

Yes.

comment:19 Changed 12 years ago by adfernandes (Andrew Fernandes)

Resolution: fixed
Status: newclosed

Thanks, pixilla, for the fix; I didn't know about the -nocomplain flag for glob.

Committed in r92922.

comment:20 Changed 12 years ago by adfernandes (Andrew Fernandes)

I think I'm getting tired. I pootched the commit. Fixed in r92923.

comment:21 Changed 12 years ago by stephen@…

Is this fix in the release yet? selfupdate doesn't seem to pull this in.

I don't know how commits works but I don't see the new code in current trunk (r93353): http://svn.macports.org/repository/macports/trunk/dports/devel/cloog/Portfile

comment:22 Changed 12 years ago by adfernandes (Andrew Fernandes)

Note - this is likely due to the recently-fixed #34477.

Note: See TracTickets for help on using tickets.