bitcoin @0.3.22 build failure (related to miniupnpc)

[fracai]

Mac OS X 10.7.4, Core 2 Duo i386

Mac OS X 10.7.4, Core i5 x86_64

I have installed "miniupnpc @1.6_0+universal" as a dependency for bitcoin and am seeing the following at the end of the bitcoin build log (I'm attaching the full log as well):

llvm-g++ -c -mmacosx-version-min=10.5  -arch x86_64 -O3 -Wno-invalid-offsetof -Wformat -g -DwxDEBUG_LEVEL=0 -I/opt/local/lib/wx/include/osx_cocoa-unicode-2.9 -I/opt/local/include/wx-2.9 -D_FILE_OFFSET_BITS=64 -DWXUSINGDLL -D__WXMAC__ -D__WXOSX__ -D__WXOSX_COCOA__  -D__WXMAC_OSX__ -DNOPCH -DMSG_NOSIGNAL=0 -DUSE_SSL -DUSE_UPNP=0 -I/opt/local/include -I/opt/local/include/db48  -DGUI -o obj/net.o net.cpp
/opt/local/include/miniupnpc/miniupnpc.h: In function ‘void ThreadMapPort2(void*)’:
/opt/local/include/miniupnpc/miniupnpc.h:56: error: too few arguments to function ‘UPNPDev* upnpDiscover(int, const char*, const char*, int, int, int*)’
net.cpp:980: error: at this point in file
/opt/local/include/miniupnpc/upnpcommands.h:124: error: too few arguments to function ‘int UPNP_AddPortMapping(const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*, const char*)’
net.cpp:994: error: at this point in file
make: *** [obj/net.o] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_finance_bitcoin/bitcoin/work/bitcoin-0.3.22/src'
shell command " cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_finance_bitcoin/bitcoin/work/bitcoin-0.3.22/src" && /usr/bin/make -j2 -w all bitcoind -f /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_finance_bitcoin/bitcoin/work/bitcoin-0.3.22/src/makefile.osx " returned error 2
Error: Target org.macports.build returned: shell command failed (see log for details)
DEBUG: Backtrace: shell command failed (see log for details)
Warning: the following items did not execute (for bitcoin): org.macports.activate org.macports.build org.macports.destroot org.macports.install
Log for bitcoin is at: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_finance_bitcoin/bitcoin/main.log

[fracai]

bitcoin build log

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #34965.

[sami.laine@…]

bitcoin build log

[sami.laine@…]

Goes same way on 10.6.8 as well.

[sami.laine@…]

I think this could be fixed simply by not using miniupnp at all. It is possible to compile bitcoin without miniupnp, by passing USE_UPNP= (yes, empty, not 0) to make. I patched the Portfile to do this, removed dependency to miniupnp, fixed a couple of directory paths passed to the linker and got a working binary.

A diff is attached in case anyone is interested.

[sami.laine@…]

diff against the original Portfile to generate a working one

[sami.laine@…]

I think this ticket might be changed to 'fixed' or 'closed', see #37353.

[easye]

bitcoin-0.8.0 now longer has miniupnp as a dependency.