Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#34480 closed enhancement (fixed)

port 2.1.0 - progress count leads to excessive lines in output

Reported by: BjarneDMat Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone: MacPorts 2.1.1
Component: base Version: 2.1.0
Keywords: Cc: neverpanic (Clemens Lang)
Port:

Description (last modified by ryandesign (Ryan Schmidt))

I'm running an automatic nightly update by having an update script as part of periodic daily.

The problem is, that the progress counts introduced in port 2.1.0

--->  Updating database of binaries: 100.0%
--->  Scanning binaries for linking errors: 100.0%

leads to an excessive amount of totally superflous lines in the log file periodic.daily.

The problem has been described in details in the groups:

Attachments (1)

mp-base-no-progress-if-stdout-no-tty.patch (4.6 KB) - added by neverpanic (Clemens Lang) 8 years ago.
Patch against base to prevent the use of \r when stdout is not a tty

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)

comment:2 Changed 8 years ago by jberry@…

Note that there is an implementation of isatty available, and defined in pextlib. It's called from at least one place inside the port command, and should probably be used here to qualify use of the eye-candy.

Changed 8 years ago by neverpanic (Clemens Lang)

Patch against base to prevent the use of \r when stdout is not a tty

comment:3 Changed 8 years ago by neverpanic (Clemens Lang)

Owner: changed from macports-tickets@… to cal@…
Status: newassigned

Please test the attached patch and report whether this works for you.

comment:4 Changed 8 years ago by neverpanic (Clemens Lang)

Milestone: MacPorts Future

comment:5 in reply to:  3 Changed 8 years ago by BjarneDMat

Replying to cal@…:

Please test the attached patch and report whether this works for you.

WORKS :-)

comment:6 Changed 8 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: assignedclosed

r93221 in trunk, cherry-pick into release 2.1 in r93222.

comment:7 Changed 8 years ago by jmroot (Joshua Root)

Milestone: MacPorts FutureMacPorts 2.1.1
Note: See TracTickets for help on using tickets.