Opened 12 years ago

Closed 12 years ago

#34505 closed defect (fixed)

port cmake pkg-config broken on 2.8.8

Reported by: anddam (Andrea D'Amore) Owned by: cssdev
Priority: Normal Milestone:
Component: ports Version: 2.1.0
Keywords: haspatch Cc:
Port: cmake

Description (last modified by anddam (Andrea D'Amore))

As per this bug report cmake 2.8.8 introduced an error, the expecting PKG_CONFIG_FOUND variable is not set when the package is found. This can be reproduced building port avidemux whose cmake configuration halts printing out "found pkg-config" and "pkg-config not found".

I'm attaching patch.

Attachments (1)

port-cmake.diff (1.3 KB) - added by anddam (Andrea D'Amore) 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by anddam (Andrea D'Amore)

Attachment: port-cmake.diff added

comment:1 Changed 12 years ago by cssdev

Status: newassigned

I'm going through the growing pains from a Lion upgrade, but I'll test the patch. Thanks!

comment:2 Changed 12 years ago by cssdev

Resolution: fixed
Status: assignedclosed

committed to r93702

comment:3 Changed 12 years ago by help@…

Resolution: fixed
Status: closedreopened

cmake version was bumped in Portfile, but this patch wasn't dropped. In result pkg-config support in cmake broke. Please revert this change. Tested using local overlay, removing patch-Modules_FindPkgConfig_cmake.diff from patchfiles works.

comment:4 in reply to:  3 Changed 12 years ago by anddam (Andrea D'Amore)

Description: modified (diff)
Resolution: fixed
Status: reopenedclosed

Replying to help@…:

cmake version was bumped in Portfile, but this patch wasn't dropped. In result pkg-config support in cmake broke. Please revert this change. Tested using local overlay, removing patch-Modules_FindPkgConfig_cmake.diff from patchfiles works.

This ticket was correctly closed, you should have raised the point in #35882 that updated cmake in r97601, please continue discussion there.

Note: See TracTickets for help on using tickets.