Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#3469 closed defect (fixed)

UPDATE: libsdl_image

Reported by: benwill@… Owned by: rshaw@…
Priority: Normal Milestone:
Component: ports Version: 1.0
Keywords: Cc:
Port:

Description

Updated portfile to make libsdl_image correctly install a framework in /Library/Frameworks on Mac OS X 10.4. This involves copying the 'darwin 7'-specific stuff to 'darwin 8'. [Perhaps there's a more elegant way?]

Attachments (5)

Portfile.diff (1.6 KB) - added by benwill@… 13 years ago.
Patch against portfile revision 4
sdl-diff.tgz (3.0 KB) - added by benwill@… 13 years ago.
Patches for sdl_* portfiles
sdl-frameworks.tgz (4.3 KB) - added by benwill@… 13 years ago.
New portfiles for sdl_* frameworks
Portfile (1.5 KB) - added by benwill@… 13 years ago.
non-functional libsdl_net-framework portfile (can't find sdl.h)
Portfile.2 (1.7 KB) - added by benwill@… 13 years ago.
New, working libsdl_net-framework portfile

Download all attachments as: .zip

Change History (15)

Changed 13 years ago by benwill@…

Attachment: Portfile.diff added

Patch against portfile revision 4

comment:1 Changed 13 years ago by mww@…

would it be possible to separate the SDL frameworks from the ordinary builds?

  1. g. make libsdl_image-framework... ports; this way we can always tell what stuff exactly

is needed by a port;

comment:2 Changed 13 years ago by benwill@…

It's easy to do, of course, and I'd do it if it's a barrier to getting the changes committed. But it'll break every port that depends on the frameworks -- fixing all of those seems like a disproportionately big job. After all, these changes are only preventing breakage on Tiger.

(In reply to comment #2)

would it be possible to separate the SDL frameworks from the ordinary builds?

  1. g. make libsdl_image-framework... ports; this way we can always tell what

stuff exactly

is needed by a port;

comment:3 Changed 13 years ago by benwill@…

Probably the right thing to do is replace the 'darwin 7' and 'darwin 8' sections with a single 'darwin'. i can't see why the frameworks shouldn't be built on darwin 6, too. The same goes for bugs 3470/3471.

comment:4 Changed 13 years ago by mww@…

I dont think that there are many ports depending on the framework build of any SDL port; separating the frameworks would be very nice as XCode stuff tends to break with every new Developer Tools release (as happened again with the latest version), and also the libsdl framework parts heavily violate porthier(1);

Changed 13 years ago by benwill@…

Attachment: sdl-diff.tgz added

Patches for sdl_* portfiles

comment:5 Changed 13 years ago by benwill@…

attachments.isobsolete: 01

Changed 13 years ago by benwill@…

Attachment: sdl-frameworks.tgz added

New portfiles for sdl_* frameworks

Changed 13 years ago by benwill@…

Attachment: Portfile added

non-functional libsdl_net-framework portfile (can't find sdl.h)

comment:6 Changed 13 years ago by benwill@…

Markus: Any chance you could take a look at this stuff? It would be very handy for me if one or other of these sets of patches were committed.

I prefer the non-upheaval version since it seems that it will be an uphill struggle to fix ports (e.g. pygame) that are broken by moving the frameworks.

comment:7 Changed 13 years ago by benwill@…

attachments.isobsolete: 01

Changed 13 years ago by benwill@…

Attachment: Portfile.2 added

New, working libsdl_net-framework portfile

comment:8 Changed 13 years ago by mww@…

ok - commited the changes to all sdl ports, except sound which gives me a strange linker error: --- ... /usr/lib/gcc/powerpc-apple-darwin8/4.0.0/../../../libm.dylib(floating.o) definition of _tgammaf /usr/bin/libtool: internal link edit command failed ---

the sdl-framework port fails with ---

Script

#!/bin/sh # make sure only public API's are exported # nmedit -s ../../src/main/macosx/SDL.x build/SDL.framework/Versions/Current/SDL # make frameworks directory if it doesn't already exist mkdir -p ./build/Frameworks # delete the old framework rm -rf ./build/Frameworks/SDL.framework # copy framework to its home /Developer/Tools/CpMac -r build/SDL.framework ./build/Frameworks/ # precompile header for speedier compiles /usr/bin/cc -precomp ./build/Frameworks/SDL.framework/Headers/SDL.h -o ./build/Frameworks/ SDL.framework/Headers/SDL.p --- Output --- failed to resolve one of the sources (-43) powerpc-apple-darwin8-gcc-4.0.0: ./build/Frameworks/SDL.framework/Headers/SDL.h: No such file or directory powerpc-apple-darwin8-gcc-4.0.0: no input files

Exit code: 1

...failed PhaseScriptExecution <Execution>/opt/local/var/db/dports/build/ file._private_var_tmp_fr_libsdl-framework/work/SDL-1.2.8/Xcode/SDL/build/SDL.build/Deployment/ Framework.build/BPTag005-script.sh ... BUILD FAILED

comment:9 Changed 13 years ago by benwill@…

(In reply to comment #11)

ok - commited the changes to all sdl ports, except sound which gives me a

strange linker error:

--- ... /usr/lib/gcc/powerpc-apple-darwin8/4.0.0/../../../libm.dylib(floating.o)

definition of _tgammaf

/usr/bin/libtool: internal link edit command failed

hmm... this works for me on 10.4.2/gcc4.0/xcode 2.0. are you using xcode 2.1?

comment:10 Changed 13 years ago by benwill@…

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.