Opened 8 years ago

Closed 8 years ago

#34922 closed defect (fixed)

osh doesn't ensure it's UsingTheRightCompiler or build_arch

Reported by: ryandesign (Ryan Schmidt) Owned by: jan+mp@…
Priority: Normal Milestone:
Component: ports Version: 2.1.1
Keywords: haspatch Cc:
Port: osh

Description

osh doesn't ensure it's UsingTheRightCompiler or build_arch

[get_canonical_archflags] is probably useful.

Attachments (1)

Portfile-osh.diff (484 bytes) - added by jan+mp@… 8 years ago.
new patch - updated on 2012-06-22

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by jan+mp@…

Thanks for the info. The attached patch fixes it up for me here. I checked the debugging outputs for both universal and non-universal builds, and it seems fine. The shells run as expected as well.

This is on iMac (w/ cpu: 2.16 GHz Intel Core 2 Duo), running OS X Lion 10.7.4, and using Xcode 4.3.3.

comment:2 Changed 8 years ago by jan+mp@…

Hello,

I've replace my previous patch with a new one. It's more correct in my estimation. Please let me know if there's something wrong with it. I welcome suggestions of course.

The new patch is against r94427 of .../shells/osh/Portfile .

Thanks, Jeff

Changed 8 years ago by jan+mp@…

Attachment: Portfile-osh.diff added

new patch - updated on 2012-06-22

comment:3 Changed 8 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added

Has duplicate #34997.

comment:4 Changed 8 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: newclosed

Committed in r94735 with a change to how the universal variant works.

Note: See TracTickets for help on using tickets.