Opened 19 years ago

Closed 19 years ago

Last modified 19 years ago

#3516 closed defect (fixed)

BUG : windowmaker comes with strange menu paths

Reported by: yves@… Owned by: olegb@…
Priority: Normal Milestone:
Component: ports Version: 1.0
Keywords: Cc:
Port:

Description

I was wondering why my windowmaker menu pointed to /opt/share and found out that many menus are totally arbitrary (for example, plmenu.it points to /opt/kde2 !) So I made a fix to change everythng to prefix

I also removed

post-destroot { file delete -force ${destroot}${prefix}/share/WindowMaker/Icons/defaultAppIcon.tiff }

because I really don't get it (?)

Attachments (2)

Portfile.diff (1.3 KB) - added by yves@… 19 years ago.
Portfile rev 1 diff
defaultAppIcon.tiff (7.5 KB) - added by yves@… 19 years ago.
I can't do better than this !

Download all attachments as: .zip

Change History (8)

Changed 19 years ago by yves@…

Attachment: Portfile.diff added

Portfile rev 1 diff

comment:1 Changed 19 years ago by olegb@…

Resolution: fixed
Status: newclosed

patch commited, thanks. (added you as co-maintainer).

the post-destroot makes sure that installation onto a case-insensitive volume doesn't break. so i havn't removed it.

comment:2 Changed 19 years ago by yves@…

about defaultAppIcon.tiff, this is what I first thought but I just don't see where it might break :

defaultAppIcon.tiff defaultAppIcon.xpm

and it make empty tiles in wmaker.

Changed 19 years ago by yves@…

Attachment: defaultAppIcon.tiff added

I can't do better than this !

comment:3 Changed 19 years ago by yves@…

attachments.mimetype: application/x-tiffimage/x-tiff

comment:4 Changed 19 years ago by yves@…

attachments.mimetype: image/x-tiffapplication/x-tiff

comment:5 Changed 19 years ago by olegb@…

WindowMaker/Icons/ contains both:

DefaultAppIcon.tiff defaultAppIcon.tiff

(they are the same files)

if you are building on a case insessitive volume, one file will just get overwritten.. no harm. If you are building on (and installing onto) a casesensiteve volume - all should be fine. BUT! if you are building on a case-sensitive volume, and installing onto a case-insensitive volume - it breaks.

there for one is removed, before installing.

comment:6 Changed 19 years ago by yves@…

Yes, I understand that, the point is that DefaultAppIcon.tiff gets overwritten at extract and so deleteing defaultAppIcon.tiff leaves neither of them. So maybe deleting -f DefaultAppIcon.tiff would be better in that regard.

Note: See TracTickets for help on using tickets.