Opened 12 years ago
Closed 12 years ago
#35316 closed defect (fixed)
frotz doesnt build under lion
| Reported by: | robert.cohen@… | Owned by: | pack-darwinports@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.1 |
| Keywords: | haspatch lion mountainlion | Cc: | ryandesign (Ryan Carsten Schmidt) |
| Port: | frotz |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
The package frotz no longer builds under lion. It appears the function getline now clashes with a MacOS function. Should be a trivial patch to rename the getline function to something like getline_local.
The build error log is
:info:build src/dumb/dumb_input.c:83: error: conflicting types for ‘getline’ :info:build /usr/include/stdio.h:449: error: previous declaration of ‘getline’ was here :info:build src/dumb/dumb_input.c: In function ‘dumb_read_line’: :info:build src/dumb/dumb_input.c:263: warning: field precision should have type ‘int’, but argument 2 has type ‘long int’ :info:build src/dumb/dumb_input.c:263: warning: field precision should have type ‘int’, but argument 2 has type ‘long int’ :info:build make: *** [src/dumb/dumb_input.o] Error 1
Attachments (2)
Change History (4)
comment:1 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | ryandesign@… added |
|---|---|
| Description: | modified (diff) |
| Keywords: | haspatch added |
| Owner: | changed from macports-tickets@… to pack-darwinports@… |
Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | patch-getline.diff added |
|---|
Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | frotz-Portfile.diff added |
|---|
comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)
| Keywords: | lion mountainlion added |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
r96098 (maintainer timeout)
Note: See
TracTickets for help on using
tickets.
Agreed. Here is a patch. Bruce, may I commit it?
P.S: Robert, please use WikiFormatting when writing in Trac.