Opened 12 years ago

Closed 10 years ago

Last modified 10 years ago

#35581 closed defect (fixed)

kde4 portgroup should not reinplace in binary files

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: Cc: cooljeanius (Eric Gallager)
Port: kde4

Description

The kde4-1.1 portgroup has this block:

post-extract {
    # Following the official word: Change #include ["<]Phonon...[">] to
    # ...phonon... in all files that contain that header.
    fs-traverse item ${worksrcpath} {
        if {[file isfile ${item}]} {
            reinplace -locale C "/#include/s@Phonon@phonon@" ${item}
        }
    }
}

This reinplace will act on all files, even images and other binary files; this is unnecessary, time-wasting, and in a worst case, possibly even destructive to those binary files. Could this be changed to only act on relevant files? For example, if these #includes would only occur in .h files, check that the file name ends in .h before running reinplace.

Change History (5)

comment:1 Changed 10 years ago by sharky@…

Cc: sharky@… removed

comment:2 Changed 10 years ago by michaelld (Michael Dickens)

Cc: michaelld@… removed

Cc Me!

comment:3 Changed 10 years ago by cooljeanius (Eric Gallager)

Nicos removed this block entirely in r115590

Last edited 10 years ago by cooljeanius (Eric Gallager) (previous) (diff)

comment:4 Changed 10 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:5 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Ok.

Note: See TracTickets for help on using tickets.