Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#35663 closed submission (fixed)

CyaSSL Embedded SSL Library

Reported by: chris@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: ssl cryptography Cc: ryandesign (Ryan Schmidt), ci42
Port: cyassl

Description

CyaSSL is a lightweight SSL implementation widely used in platforms ranging from small embedded systems up to enterprise cloud environments. It provides SSL/TLS/DTLS support as well as an underlying cryptography library, CTaoCrypt.

The new Portfile is attached for review.

Thanks, Chris (yaSSL)

Attachments (1)

Portfile (2.2 KB) - added by chris@… 9 years ago.
Updated cyassl Portfile

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by ryandesign (Ryan Schmidt)

Cc: chris@… removed

Some initial comments:

  • The homepage line is invalid; it needs to be a valid URL, beginning with a protocol such as http://
  • The distfiles line can be removed because that is the default.
  • The empty depends_lib line can be removed because you're not actually adding any dependencies there and the default is for a port to have no dependencies.
  • There are too many variants. Variants should be added sparingly and only for features that are expensive to build and that most users would not want. For most of the variants you've shown here, especially those that don't add dependencies, you should probably just turn those features on in the main part of the portfile and not give the user a way to turn them off.

Changed 9 years ago by chris@…

Attachment: Portfile added

Updated cyassl Portfile

comment:2 Changed 9 years ago by chris@…

Thanks for the feedback. I have made your suggested changes and attached an updated Portfile.

comment:3 Changed 9 years ago by ci42

Resolution: fixed
Status: newclosed

Thanks. Added in r96573. CyaSSL doesn't build with clang, so I modified the Portfile to ensure that llvm-gcc-4.2 is used instead of clang (see wiki:PortfileRecipes#compiler).

comment:4 Changed 9 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… ciserlohn@… added

Christoph, don't forget to use TracLinks; I've fixed yours above. Actually it's simpler to just write "compiler.blacklist clang"; I changed that in r96590. I also fixed a typo in the categories line. We should update PortfileRecipes with information about how to use compiler.blacklist instead, except I'm not sure how it works in the case where you also need to add dependencies, like for apple-gcc42.

Note: See TracTickets for help on using tickets.