Opened 8 years ago

Closed 8 years ago

#36400 closed defect (fixed)

pgAdmin3: change variant names

Reported by: ryandesign (Ryan Schmidt) Owned by: jyrkiwahlstedt
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: haspatch Cc:
Port: pgAdmin3


$ port info pgAdmin3 |head -n 2
pgAdmin3 @1.16.0 (aqua)
Variants:             debug, with_postgresql83, with_postgresql84, with_postgresql90, with_postgresql91, [+]with_postgresql92

The variant names should be changed. Variant names should not begin with a "with_" prefix.

The old variant names should be retained for one year, marked as requiring the new variant names, to facilitate upgrades.

The attached patch does this, and simplifies the variants as well by removing unnecessary directives.

The way the default variant is selected is also improved so that users wishing to use a non-default variant do not encounter an error message about variant conflicts.

Attachments (1)

pgAdmin3-variants.diff (3.7 KB) - added by ryandesign (Ryan Schmidt) 8 years ago.

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by ryandesign (Ryan Schmidt)

Attachment: pgAdmin3-variants.diff added

comment:1 Changed 8 years ago by jyrkiwahlstedt

Resolution: fixed
Status: newclosed

done in r98257

Note: See TracTickets for help on using tickets.