port splash: build failed

[wd11@…]

Error: org.macports.build for port splash returned: command execution failed
Please see the log file for port splash for details: /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_splash/splash/main.log
To report a bug, follow the instructions in the guide:
    http://guide.macports.org/#project.tickets
Error: Processing of port splash failed

in that file:

:info:build /usr/bin/clang -arch x86_64 -I/opt/local/include -I/include -c ../src/read_data_gadget_hdf5_utils.c -o read_data_gadget_hdf5_utils.o
:info:build ../src/read_data_gadget_hdf5_utils.c:70:18: error: token is not a valid binary operator in a preprocessor subexpression
:info:build #if H5_VERSION_GE(1,8,0)
:info:build     ~~~~~~~~~~~~~^
:info:build ../src/read_data_gadget_hdf5_utils.c:151:18: error: token is not a valid binary operator in a preprocessor subexpression
:info:build #if H5_VERSION_GE(1,8,0)
:info:build     ~~~~~~~~~~~~~^
:info:build ../src/read_data_gadget_hdf5_utils.c:211:18: error: token is not a valid binary operator in a preprocessor subexpression
:info:build #if H5_VERSION_GE(1,8,0)
:info:build     ~~~~~~~~~~~~~^
:info:build ../src/read_data_gadget_hdf5_utils.c:279:18: error: token is not a valid binary operator in a preprocessor subexpression
:info:build #if H5_VERSION_GE(1,8,0)
:info:build     ~~~~~~~~~~~~~^
:info:build ../src/read_data_gadget_hdf5_utils.c:354:18: error: token is not a valid binary operator in a preprocessor subexpression
:info:build #if H5_VERSION_GE(1,8,0)
:info:build     ~~~~~~~~~~~~~^
:info:build ../src/read_data_gadget_hdf5_utils.c:482:18: error: token is not a valid binary operator in a preprocessor subexpression
:info:build #if H5_VERSION_GE(1,8,0)
:info:build     ~~~~~~~~~~~~~^
:info:build 6 errors generated.

[wd11@…]

main.log (macro H5_VERSION_GE was introduced with version 1.8.X, but this is version 1.6.9)

[wd11@…]

It seems to me that choosing port hdf5 as dependency causes the issue. hdf5 is version 1.6.9 which doesn't define the macro H5_VERSION_GE used in the source code failing to compile. So either fix that source code (by directly using the version macros H5_VERS_MAJOR, H5_VERS_MINOR, and H5_VERS_RELEASE) or choose hdf5-18 as dependency, or both. cheers, Walter.

[danieljprice (Daniel Price)]

please see ticket #36316. I have submitted a patch for this, but just waiting for it to be committed.