Opened 10 years ago

Closed 10 years ago

#36470 closed defect (fixed)

py27-pygrib: error: use of undeclared identifier 'voidp'; did you mean 'void'?

Reported by: tylordippel@… Owned by: jswhit (Jeff Whitaker)
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: Cc: nerdling (Jeremy Lavergne), EJFielding (Eric Fielding), peeter.as@…
Port: py27-pygrib

Description (last modified by ryandesign (Ryan Schmidt))

After installing Macports, I entered sudo port install py27-pygrib. Many of the dependencies were installed; however, when it got the the py27-pygrib installer, I got an error. I installed macports with the package installer and have the xcode commend line tools installed. Here is what the log file said:

(pasted log removed by admin; see attachment)

Attachments (3)

main.log (39.0 KB) - added by tylordippel@… 10 years ago.
Portfile (1.1 KB) - added by jswhit (Jeff Whitaker) 10 years ago.
new Portfile for py-pygrib (version 1.9.5)
Portfile.diff (987 bytes) - added by jswhit (Jeff Whitaker) 10 years ago.
Portfile diff

Download all attachments as: .zip

Change History (17)

Changed 10 years ago by tylordippel@…

Attachment: main.log added

comment:1 Changed 10 years ago by tylordippel@…

I've also attached the log file.

comment:2 Changed 10 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)
Owner: changed from macports-tickets@… to jswhit@…
Port: py27-pygrib added
Priority: HighNormal
Summary: Unable to install py27-pygribpy27-pygrib: error: use of undeclared identifier 'voidp'; did you mean 'void'?

comment:3 Changed 10 years ago by jmroot (Joshua Root)

It should be png_voidp, and it seems to be fixed upstream.

comment:4 Changed 10 years ago by nerdling (Jeremy Lavergne)

Cc: snc@… added

Cc Me!

comment:5 Changed 10 years ago by EJFielding (Eric Fielding)

Cc: Eric.J.Fielding@… added

Cc Me!

comment:6 Changed 10 years ago by peeter.as@…

Cc: peeter.as@… added

Cc Me!

comment:7 Changed 10 years ago by EJFielding (Eric Fielding)

As a temporary patch, I was able to get the existing pygrib 1.9.2 code to build with the change suggested by jmr above (voidp should be png_voidp). I went into the work directory of a failed build (.../py27-pygrib/work/pygrib-1.9.2) and edited these two files:

g2clib_src/dec_png.c
g2clib_src/enc_png.c

On line 91 of both files, change "voidp" to "png_voidp".

EDIT: Then just run "port install" again.

Last edited 10 years ago by EJFielding (Eric Fielding) (previous) (diff)

comment:8 Changed 10 years ago by jswhit (Jeff Whitaker)

This is fixed in newer versions of pygrib - so upgrading the package to use pygrib-1.9.5 will solve this issue.

comment:9 in reply to:  7 Changed 10 years ago by peeter.as@…

Replying to Eric.J.Fielding@…:

As a temporary patch, I was able to get the existing pygrib 1.9.2 code to build with the change suggested by jmr above (voidp should be png_voidp). I went into the work directory of a failed build (py27-pygrib/work/pygrib-1.9.2) and edited these two files:

g2clib_src/dec_png.c
g2clib_src/enc_png.c

On line 91 of both files, change "voidp" to "png_voidp".

Thank you for the information!

Which port commands to use to recompile after changing the source file?

EDIT. I got it installed now. I overlooked something probably.

Last edited 10 years ago by peeter.as@… (previous) (diff)

comment:10 in reply to:  8 Changed 10 years ago by mf2k (Frank Schima)

Replying to jswhit@…:

This is fixed in newer versions of pygrib - so upgrading the package to use pygrib-1.9.5 will solve this issue.

You are the maintainer of this port, so supplying a patch would be considered part of that job.

Changed 10 years ago by jswhit (Jeff Whitaker)

Attachment: Portfile added

new Portfile for py-pygrib (version 1.9.5)

comment:11 Changed 10 years ago by jswhit (Jeff Whitaker)

OK, here's a new Portfile. Is this the right place to submit it, or should I open a new ticket?

comment:12 Changed 10 years ago by mf2k (Frank Schima)

This ticket is fine. But please submit a unified diff of the portfile against trunk so we can see what changes you made.

Changed 10 years ago by jswhit (Jeff Whitaker)

Attachment: Portfile.diff added

Portfile diff

comment:13 Changed 10 years ago by jswhit (Jeff Whitaker)

unified diff attached

comment:14 Changed 10 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed

Thanks! r99881.

Note: See TracTickets for help on using tickets.