Opened 8 years ago
Closed 8 years ago
#36604 closed update (fixed)
fann version 2.2.0 upgrade
| Reported by: | mgrimes@… | Owned by: | mwilliams256@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.2 |
| Keywords: | haspatch | Cc: | ryandesign (Ryan Schmidt) |
| Port: | fann |
Description
The attached patch upgrades to version 2.2.0 of fann. Thanks, Mark
Attachments (2)
Change History (6)
Changed 8 years ago by mgrimes@…
| Attachment: | Portfile-fann.diff added |
|---|
comment:1 Changed 8 years ago by mgrimes@…
| Cc: | mgrimes@… added |
|---|
comment:2 follow-up: 3 Changed 8 years ago by ryandesign (Ryan Schmidt)
| Cc: | ryandesign@… added; mgrimes@… removed |
|---|---|
| Keywords: | haspatch added |
| Owner: | changed from macports-tickets@… to mwilliams256@… |
Thanks.
There's no need to Cc yourself when you are the reporter, but you should Cc the port's maintainer so that he can sign off on the update. Also remember to use the "haspatch" keyword when you are attaching a patch.
There's no need to set both distfiles and worksrcdir; you can just set distname.
md5 and sha1 checksum types are deprecated. We would prefer to see rmd160 and sha256 checksum types on new ports and port updates.
The master_sites line should not be changed; it was correct as written. Your change introduces http redirects which slow down the download for users and mean they're not necessarily downloading from the fastest mirror.
I'm attaching a revised patch. Mitch, may I commit it?
Changed 8 years ago by ryandesign (Ryan Schmidt)
| Attachment: | fann-2.2.0.diff added |
|---|
revised port update proposal
comment:3 follow-up: 4 Changed 8 years ago by jmroot (Joshua Root)
Replying to ryandesign@…:
md5 and sha1 checksum types are deprecated. We would prefer to see rmd160 and sha256 checksum types on new ports and port updates.
You'd better convince sourceforge to provide them then.
comment:4 Changed 8 years ago by ryandesign (Ryan Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Replying to ryandesign@…:
I'm attaching a revised patch. Mitch, may I commit it?
I've committed it in r99477.
Replying to jmr@…:
Replying to ryandesign@…:
md5 and sha1 checksum types are deprecated. We would prefer to see rmd160 and sha256 checksum types on new ports and port updates.
You'd better convince sourceforge to provide them then.
I guess this matter concerns more than just this port, so if any further discussion is needed, we can have that on the macports-dev mailing list.
Cc Me!