Opened 8 years ago

Last modified 7 years ago

#36855 new defect

munin: "load" plugin uses bad echo command

Reported by: mf-macports.org@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: haspatch Cc:
Port: munin

Description

The "load" plugin currently uses echo -n in a script executed by /bin/sh, which is not an available option in this builtin.

The attached patch substitutes the -n option with a \c at the end of the string.

Attachments (1)

patch-munin.loadpluginechofix (1.1 KB) - added by mf-macports.org@… 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by mf-macports.org@…

comment:1 Changed 8 years ago by ryandesign (Ryan Schmidt)

Cc: alpha@… removed
Owner: changed from macports-tickets@… to alpha@…
Summary: "load" plugin in munin uses bad echo commandmunin: "load" plugin uses bad echo command

Since this changes a file that ends up getting installed, the revision should be increased.

It looks like the load plugin isn't the only plugin that uses "echo -n"; as far as I can tell all of the following plugins do:

  • id
  • load
  • netopia
  • ntp_kernel_err
  • ntp_kernel_pll_freq
  • ntp_kernel_pll_off
  • qmailscan
  • qmailscan-simple
  • snort_alerts
  • snort_bytes_pkt
  • snort_drop_rate
  • snort_pattern_match
  • snort_pkts
  • snort_traffic
  • squeezebox_

Instead of manually fixing these, we should probably just update to a newer version. According the ChangeLog, "echo -n" was replaced with "printf" in version 2.0-alpha2; this is the fix we've used in other ports too.

comment:2 Changed 7 years ago by mf2k (Frank Schima)

Owner: changed from alpha@… to macports-tickets@…

This port is no longer maintained.

Note: See TracTickets for help on using tickets.