fluidsynth @1.1.6_0 Patch to allow successful build on Tiger

[ccarey@…]

The fluidsynth @1.1.6_0 port does not successfully build on Tiger because of

:info:build libtool: compile:  /usr/bin/gcc-4.0 -DHAVE_CONFIG_H -I. -I../include -I../src -I../src/drivers -I../src/synth -I../src/rvoice -I../src/midi -I../src/utils -I../src/sfloader -I../src/bindings -I/opt/local/include -I/opt/local/include -D_REENTRANT -I/opt/local/include/glib-2.0 -I/opt/local/lib/glib-2.0/include -I/opt/local/include -I/opt/local/include -I/opt/local/include/dbus-1.0 -I/opt/local/lib/dbus-1.0/include -I/opt/local/include -pipe -O2 -arch ppc -O2 -fomit-frame-pointer -funroll-all-loops -finline-functions -Wall -W -Wpointer-arith -Wbad-function-cast -Wcast-qual -Wcast-align -Wstrict-prototypes -Winline -Wno-unused-parameter -Wno-cast-qual -MT drivers/libfluidsynth_la-fluid_coreaudio.lo -MD -MP -MF drivers/.deps/libfluidsynth_la-fluid_coreaudio.Tpo -c drivers/fluid_coreaudio.c  -fno-common -DPIC -o drivers/.libs/libfluidsynth_la-fluid_coreaudio.o
:info:build In file included from ../src/synth/fluid_event_queue.h:24,
:info:build                  from ../src/synth/fluid_synth.h:35,
:info:build                  from drivers/fluid_coreaudio.c:27:
:info:build ../src/utils/fluid_sys.h: In function 'new_fluid_cond_mutex':
:info:build ../src/utils/fluid_sys.h:161: warning: 'g_thread_init' is deprecated (declared at /opt/local/include/glib-2.0/glib/deprecated/gthread.h:259)
:info:build ../src/utils/fluid_sys.h:162: warning: 'g_mutex_new' is deprecated (declared at /opt/local/include/glib-2.0/glib/deprecated/gthread.h:271)
:info:build In file included from /System/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/OSServices.h:46,
:info:build                  from /System/Library/Frameworks/CoreServices.framework/Headers/CoreServices.h:25,
:info:build                  from drivers/fluid_coreaudio.c:36:
:info:build /System/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/OpenTransportProviders.h: At top level:
:info:build /System/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/OpenTransportProviders.h:108: error: parse error before numeric constant
:info:build /System/Library/Frameworks/CoreServices.framework/Frameworks/OSServices.framework/Headers/OpenTransportProviders.h:116: error: parse error before numeric constant
:info:build make[2]: *** [drivers/libfluidsynth_la-fluid_coreaudio.lo] Error 1

The attached patch fixes the problem by adapting the Tiger-specific workaround in src/drivers/fluid_coremidi.c to src/drivers/fluid_coreaudio.c also.

[ccarey@…]

patch to src/drivers/fluid_coremidi.c to more closely match <netinet/tcp.h>

[ccarey@…]

patch to src/drivers/fluid_coreaudio.c to allow fluidsynth @1.1.6_0 to build successfully on Tiger

[ryandesign (Ryan Carsten Schmidt)]

Supersedes #36292.

[ryandesign (Ryan Carsten Schmidt)]

Is there an upstream bug report for this problem? Do the developers already know about this patch?

[ccarey@…]

Replying to ryandesign@…:

Is there an upstream bug report for this problem? Do the developers already know about this patch?

I don’t know the answer to either question.

[ryandesign (Ryan Carsten Schmidt)]

Then I assume you developed this patch? Could you report the problem and the solution to the developers please? That way they can incorporate it into their sources.

[kencu (Ken)]

Just an FYI for anyone out there still using Tiger: this patch still works perfectly well to enable the build of fluidsynth @1.1.6_6 on Tiger. Added to the fixes in my macports Tiger repo at <​https://github.com/kencu/TigerPorts>. This was required for scummvm @1.9.0 to build on Tiger.

[mojca (Mojca Miklavec)]

In 13194e9f2e8894cf8bc3af1433efb5c19636ee48/macports-ports (master):

fluidsynth: fix build on Tiger

Closes: #36962