sodipodi will not build with libpng 1.5

[amadeus24]

Last lines of sodipodi build-log:

:info:build 2 warnings and 2 errors generated.
:info:build make[4]: *** [png-write.o] Error 1
:info:build make[4]: *** Waiting for unfinished jobs....
:info:build make[4]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_sodipodi/sodipodi/work/sodipodi-0.34/src/helper'
:info:build make[3]: *** [all] Error 2
:info:build make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_sodipodi/sodipodi/work/sodipodi-0.34/src/helper'
:info:build make[2]: *** [all-recursive] Error 1
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_sodipodi/sodipodi/work/sodipodi-0.34/src'
:info:build make[1]: *** [all-recursive] Error 1
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_sodipodi/sodipodi/work/sodipodi-0.34'
:info:build make: *** [all] Error 2
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_sodipodi/sodipodi/work/sodipodi-0.34'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_gnome_sodipodi/sodipodi/work/sodipodi-0.34" && /usr/bin/make -j4 -w all 
:info:build Exit code: 2
:error:build org.macports.build for port sodipodi returned: command execution failed
:debug:build Error code: CHILDSTATUS 77652 2
:debug:build Backtrace: command execution failed
    while executing
"system -nice 0 $fullcmdstring"
    ("eval" body line 1)
    invoked from within
"eval system $notty $nice \$fullcmdstring"
    invoked from within
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"$procedure $targetname"
:info:build Warning: targets not executed for sodipodi: org.macports.activate org.macports.build org.macports.destroot org.macports.install

[ryandesign (Ryan Carsten Schmidt)]

The relevant part of the log is:

:info:build png-write.c:285:21: error: incomplete definition of type 'struct png_struct_def'
:info:build         if (setjmp (png_ptr->jmpbuf)) {
:info:build                     ~~~~~~~^
:info:build /opt/local/include/png.h:857:16: note: forward declaration of 'struct png_struct_def'
:info:build typedef struct png_struct_def png_struct;
:info:build                ^
:info:build png-write.c:373:27: error: incomplete definition of type 'struct png_struct_def'
:info:build                 if (!n) longjmp (png_ptr->jmpbuf, 1);
:info:build                                  ~~~~~~~^
:info:build /opt/local/include/png.h:857:16: note: forward declaration of 'struct png_struct_def'
:info:build typedef struct png_struct_def png_struct;
:info:build                ^

So this is the usual symptom of incompatibility with libpng 1.5. We need to update the port to a newer version or patch this problem ourselves.

[ryandesign (Ryan Carsten Schmidt)]

No newer version exists; this software appears to have been abandoned by its developers in 2004.

I found a patch for libpng 1.5 compatibility here: ​http://cvs.pld-linux.org/cgi-bin/viewvc.cgi/cvs/packages/sodipodi/sodipodi-libpng15.patch?revision=1.2&view=markup

[ryandesign (Ryan Carsten Schmidt)]

r99665