Opened 6 years ago

Closed 6 years ago

#37031 closed submission (fixed)

Toluapp Portfile

Reported by: bradc6 (Bradley Clemetson) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: toluapp

Description

I would like to add my Portfile to allow OSX users to easily install tolua++. The original code is @ http://www.codenix.com/~tolua/ (Which seems to not be maintained). I found this luadist project @ https://github.com/LuaDist/ and created the following Portfile.

Thank You

Attachments (1)

Portfile (1.7 KB) - added by bradc6 (Bradley Clemetson) 6 years ago.
Revised Portfile

Download all attachments as: .zip

Change History (13)

comment:1 Changed 6 years ago by bradc6 (Bradley Clemetson)

Cc: brad.clemetson@… added

Cc Me!

comment:2 Changed 6 years ago by bradc6 (Bradley Clemetson)

Cc: brad.clemetson@… removed

Cc Me!

comment:3 Changed 6 years ago by bradc6 (Bradley Clemetson)

Cc: brad.clemetson@… added

Cc Me!

comment:4 Changed 6 years ago by ryandesign (Ryan Schmidt)

Thanks. Some initial comments:

  • Since this project is hosted at github, please try using the github portgroup.
  • A fetch dependency on git-core needn't be added; MacPorts base does so for you automatically when fetch.type is git.
    • But if possible, fetch a tarball, not from git.
    • I see there's a tag for 1.0.93; perhaps that's what the version should be, and the tarball that should be downloaded.
  • /opt/local should not be hardcoded; use ${prefix} instead.
    • But -DCMAKE_INSTALL_PREFIX needn't be set manually; the cmake portgroup sets it for you.
  • In MacPorts we usually replace "+"s in project names with "x"s not "p"s.
    • But since the project seems to be referred to as toluapp by upstream in a few places already I guess we can keep that name too.

comment:5 Changed 6 years ago by bradc6 (Bradley Clemetson)

ok, I'll make those changes and attach a new one. (First time making a Portfile)

comment:6 Changed 6 years ago by bradc6 (Bradley Clemetson)

I think I have implemented the changes above but I am not sure where to get/generate the correct checksums for version 1.0.93?

(Fixed) Thank You

Last edited 6 years ago by bradc6 (Bradley Clemetson) (previous) (diff)

comment:7 Changed 6 years ago by mf2k (Frank Schima)

A few more observations:

  • When using portgroups, you should always -append dependencies so you don't override the ones that the portgroup already adds.
  • Since you are using the cmake portgroup, you do not need to add a dependency on cmake.
  • You should remove the URL from the long_description.
  • The configure.post_args .. line looks suspicious to me. What are you trying to accomplish there?
  • You can get the correct checksums by first running port -v checksum and using the value that it suggests in the output.

comment:8 Changed 6 years ago by mf2k (Frank Schima)

Cc: brad.clemetson@… removed
Port: toluapp added
Version: 2.1.2

The reporter is automatically Cc'ed.

Changed 6 years ago by bradc6 (Bradley Clemetson)

Attachment: Portfile added

Revised Portfile

comment:9 Changed 6 years ago by bradc6 (Bradley Clemetson)

Made those additional changes, the only thing I am not certain of is if I implemented the -append correctly

For "configure.post_args .." is used to tell Cmake where CMakelists.txt is located. I think what it does is it creates a directory called build and changes into that directory. Which then cmake is called and the post_args tells it to look for the build configuration one directory above it.

comment:10 Changed 6 years ago by bradc6 (Bradley Clemetson)

Are there additional changes I should make?

comment:11 Changed 6 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks. Only other thing is that the github.setup line is meant to replace the name, version and homepage lines.

comment:12 Changed 6 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

r100161 with those changes and a little minor reformatting.

And yes "configure.post_args .." is one way that cmake ports can do part of doing an out-of-source build. See #33259 for efforts to streamline this.

Note: See TracTickets for help on using tickets.