Toluapp Portfile

[bradc6 (Bradley Clemetson)]

I would like to add my Portfile to allow OSX users to easily install tolua++. The original code is @ ​http://www.codenix.com/~tolua/ (Which seems to not be maintained). I found this luadist project @ ​https://github.com/LuaDist/ and created the following Portfile.

Thank You

[bradc6 (Bradley Clemetson)]

Cc Me!

[bradc6 (Bradley Clemetson)]

Cc Me!

[bradc6 (Bradley Clemetson)]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Some initial comments:

• Since this project is hosted at github, please try using the github portgroup.
• A fetch dependency on git-core needn't be added; MacPorts base does so for you automatically when fetch.type is git.
  • But if possible, fetch a tarball, not from git.
  • I see there's a tag for 1.0.93; perhaps that's what the version should be, and the tarball that should be downloaded.
• /opt/local should not be hardcoded; use ${prefix} instead.
  • But -DCMAKE_INSTALL_PREFIX needn't be set manually; the cmake portgroup sets it for you.
• In MacPorts we usually replace "+"s in project names with "x"s not "p"s.
  • But since the project seems to be referred to as toluapp by upstream in a few places already I guess we can keep that name too.

[bradc6 (Bradley Clemetson)]

ok, I'll make those changes and attach a new one. (First time making a Portfile)

[bradc6 (Bradley Clemetson)]

I think I have implemented the changes above but I am not sure where to get/generate the correct checksums for version 1.0.93?

(Fixed) Thank You

[mf2k (Frank Schima)]

A few more observations:

• When using portgroups, you should always -append dependencies so you don't override the ones that the portgroup already adds.
• Since you are using the cmake portgroup, you do not need to add a dependency on cmake.
• You should remove the URL from the long_description.
• The configure.post_args .. line looks suspicious to me. What are you trying to accomplish there?
• You can get the correct checksums by first running port -v checksum and using the value that it suggests in the output.

[mf2k (Frank Schima)]

The reporter is automatically Cc'ed.

[bradc6 (Bradley Clemetson)]

Revised Portfile

[bradc6 (Bradley Clemetson)]

Made those additional changes, the only thing I am not certain of is if I implemented the -append correctly

For "configure.post_args .." is used to tell Cmake where CMakelists.txt is located. I think what it does is it creates a directory called build and changes into that directory. Which then cmake is called and the post_args tells it to look for the build configuration one directory above it.

[bradc6 (Bradley Clemetson)]

Are there additional changes I should make?

[ryandesign (Ryan Carsten Schmidt)]

Thanks. Only other thing is that the github.setup line is meant to replace the name, version and homepage lines.

[ryandesign (Ryan Carsten Schmidt)]

r100161 with those changes and a little minor reformatting.

And yes "configure.post_args .." is one way that cmake ports can do part of doing an out-of-source build. See #33259 for efforts to streamline this.