plplot: use cmake portgroup

[ryandesign (Ryan Carsten Schmidt)]

The plplot portfile could probably be simplified by using the cmake portgroup.

[tenomoto (Takeshi Enomoto)]

Committed in r99949.

[ryandesign (Ryan Carsten Schmidt)]

There were still a couple problems.

The cmake build dependency got removed; you probably received a ​buildbot failure notification about that. Fixed in r99952 by appending to, instead of overwriting, the portgroup's dependencies.

There was still some code setting the variables cflags and cxxflags, but those variables were no longer used so I removed this code in r99953.

The port still sets CMAKE_OSX_ARCHITECTURES manually, but the cmake portgroup does that for you. In fact it looks like in some cases (when the g95 variant is set and the universal variant is not set) the port wants CMAKE_OSX_ARCHITECTURES not to be set at all? If that's truly required, then I'm not sure if the cmake portgroup accommodates that need. Perhaps we can explore this further to find out why the port is doing this.

[tenomoto (Takeshi Enomoto)]

The problem is that gfortran-mp-4.x fails with -arch. I reverted to r99948 in r99965. It would be nice if PortGroup cmake had a feature to remove -arch when a fortran compiler is used.

[jmroot (Joshua Root)]

Does setting CMAKE_OSX_ARCHITECTURES cause cmake to pass -arch flags to every compiler used? Is that correct behaviour on cmake's part?

[tenomoto (Takeshi Enomoto)]

See also #37732.

[cooljeanius (Eric Gallager)]

Cc Me!

[mojca (Mojca Miklavec)]

Could you please check this again now that the latest versions of GCC ignore the -arch flag?

[tenomoto (Takeshi Enomoto)]

Done in r140213 and r140229 for plplot and 140230 for plplot-single.