Opened 8 years ago

Closed 8 years ago

#37130 closed enhancement (wontfix)

github portgroup: github.tarball_from downloads should set livecheck.url

Reported by: lpsinger (Leo Singer) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: Cc: anddam (Andrea D'Amore), ryandesign (Ryan Schmidt)
Port:

Description

I maintain a pair of ports, gst-plugins-cairovis and gst-plugins-math, which are hosted on GitHub (and of which I am the author). I generate and upload stable source tarballs under the projects' respective downloads on GitHub. I just realized that the livecheck for these ports is busted. I had to override the defaults by adding the following:

livecheck.url         https://github.com/${github.author}/${name}/downloads
livecheck.regex       ${name}-(\\d+(\\.\\d+)*)[regsub -all \\. ${extract.suffix} \\.]

It is understandable that I would have to write my own regex, but it would be nice if

github.tarball_from   downloads

automatically set livecheck.url to something useful.

Attachments (2)

gst-plugins-cairovis.diff (923 bytes) - added by ryandesign (Ryan Schmidt) 8 years ago.
gst-plugins-math.diff (874 bytes) - added by ryandesign (Ryan Schmidt) 8 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

I thought about this problem when creating the portgroup, but didn't solve it then because there were not that many ports needing to download from downloads instead of tags, and even fewer of those that had downloads but not tags.

Your projects have tags, so why not let the default github portgroup livecheck use those?

The fourth argument to github.setup is currently called tag_prefix. If we're going to change the livecheck when downloads are from downloads and not from tags, then that parameter's name should be changed, since then it would be the prefix of either the tag or the download.

Changed 8 years ago by ryandesign (Ryan Schmidt)

Attachment: gst-plugins-cairovis.diff added

Changed 8 years ago by ryandesign (Ryan Schmidt)

Attachment: gst-plugins-math.diff added

comment:2 in reply to:  1 ; Changed 8 years ago by ryandesign (Ryan Schmidt)

Replying to ryandesign@…:

Your projects have tags, so why not let the default github portgroup livecheck use those?

As in the attached patches.

comment:3 in reply to:  2 Changed 8 years ago by ryandesign (Ryan Schmidt)

Resolution: wontfix
Status: newclosed

Replying to ryandesign@…:

As in the attached patches.

r101096, r101097.

As for the main point of this ticket—using downloads for livecheck—I think we can now justify not doing so, since the github uploads/downloads feature has been deprecated: https://github.com/blog/1302-goodbye-uploads

Note: See TracTickets for help on using tickets.