Opened 7 years ago

Closed 7 years ago

#37234 closed update (fixed)

py-request: update to 0.14.1

Reported by: larryv (Lawrence Velázquez) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: haspatch maintainer Cc: saispo@…
Port: py-requests

Description

Self-explanatory.

Attachments (2)

Portfile-py-requests.diff (801 bytes) - added by larryv (Lawrence Velázquez) 7 years ago.
Portfile-py-requests-0.14.1.diff (1.2 KB) - added by larryv (Lawrence Velázquez) 7 years ago.
update to 0.14.1

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by larryv (Lawrence Velázquez)

Attachment: Portfile-py-requests.diff added

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

The py3* subports don't build:

Traceback (most recent call last):
  File "setup.py", line 6, in <module>
    import requests
  File "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_python_py-requests/py31-requests/work/requests-0.14.2/requests/__init__.py", line 52, in <module>
    from . import utils
  File "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_python_py-requests/py31-requests/work/requests-0.14.2/requests/utils.py", line 22, in <module>
    from .compat import parse_http_list as _parse_list_header
  File "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_python_py-requests/py31-requests/work/requests-0.14.2/requests/compat.py", line 112, in <module>
    from .packages import chardet2 as chardet
ImportError: cannot import name chardet2
Traceback (most recent call last):
  File "setup.py", line 6, in <module>
    import requests
  File "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_python_py-requests/py32-requests/work/requests-0.14.2/requests/__init__.py", line 52, in <module>
    from . import utils
  File "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_python_py-requests/py32-requests/work/requests-0.14.2/requests/utils.py", line 22, in <module>
    from .compat import parse_http_list as _parse_list_header
  File "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_python_py-requests/py32-requests/work/requests-0.14.2/requests/compat.py", line 112, in <module>
    from .packages import chardet2 as chardet
ImportError: cannot import name chardet2

comment:2 Changed 7 years ago by larryv (Lawrence Velázquez)

Hm. The tarball hosted at PyPI is missing the chardet2 package, while the one at GitHub has it.

% ls requests-0.14.2-pypi/requests/packages
__init__.py	chardet/	oauthlib/	urllib3/
% ls requests-0.14.2-github/requests/packages
__init__.py	chardet/	chardet2/	oauthlib/	urllib3/

Not sure what the best course of action here is. Should we just grab the tarball from GitHub?

comment:3 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

There seems to be a bit of difference between the two requests-0.14.2s:

$ diff -ru {github,pypi}/requests-0.14.2
Only in github/requests-0.14.2: .env
Only in github/requests-0.14.2: .gitignore
Only in github/requests-0.14.2: .travis.yml
Only in github/requests-0.14.2: AUTHORS.rst
Only in github/requests-0.14.2: Makefile
Only in pypi/requests-0.14.2: PKG-INFO
Only in github/requests-0.14.2: docs
Only in github/requests-0.14.2: ext
Only in pypi/requests-0.14.2/requests: adapters.py
Only in github/requests-0.14.2/requests/packages: chardet2
Only in github/requests-0.14.2/requests/packages/urllib3: contrib
Only in pypi/requests-0.14.2: requests.egg-info
Only in github/requests-0.14.2: requirements.txt
Only in pypi/requests-0.14.2: setup.cfg
Only in github/requests-0.14.2: tests

If the one from github works, I guess we should use that. My concern would be if any of the files in the pypi version that aren't in the github version are needed.

I note from the github history that chardet has already been removed from the project in favor of charade so I guess this problem will fix itself with the next release.

comment:4 in reply to:  3 Changed 7 years ago by larryv (Lawrence Velázquez)

Replying to ryandesign@…:

I note from the github history that chardet has already been removed from the project in favor of charade so I guess this problem will fix itself with the next release.

We could wait on 0.14.3. In the meantime, 0.14.1 seems to work fine, so let's at least update to that. I also added a subport for Python 3.3.

Changed 7 years ago by larryv (Lawrence Velázquez)

update to 0.14.1

comment:5 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… removed
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned
Summary: py-requests @0.13.6 - update to 0.14.2py-request: update to 0.14.1

comment:6 Changed 7 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.