Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#37397 closed submission (fixed)

NEW: pinpoint 0.1.2

Reported by: macports@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: pinpoint

Description

I'm not from pinpoint project but I use it for my presentations. Some features of pinpoint are not working but I want to submit patchs to the project to fix them.

Pinpoint is a simple presentation tool that hopes to avoid audience death by bullet point and instead encourage presentations containing beautiful images and small amounts of concise text in slides.

Attachments (2)

pinpoint.diff (594 bytes) - added by macports@… 8 years ago.
patch to compile
Portfile (1.2 KB) - added by macports@… 8 years ago.
Portfile of pinpoint 0.1.2

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by macports@…

Attachment: pinpoint.diff added

patch to compile

comment:1 Changed 8 years ago by ryandesign (Ryan Schmidt)

Thank you. Some comments:

  • Is there a distfile that could be used instead of fetching from git? If so that would be preferable.
  • autoconf is probably only a build dependency, not a library dependency.
  • The cairo dependency should be written such that cairo-devel could satisfy it. See other ports that depend on cairo.
  • The standard modeline should be added, and the portfile's whitespace ensured to conform to it.
  • Can it be determined which version(s) of the GPL this is licensed under? If so, the license line should so indicate.

comment:2 Changed 8 years ago by macports@…

What is the main difference between cairo and cairo-devel? I'm not sure about how to resolve this dependency.

comment:3 Changed 8 years ago by macports@…

Resolved! cairo is a dependency for clutter, and clutter already is a dependency for pinpoint. So, I removed cairo from the dependency list.

Changed 8 years ago by macports@…

Attachment: Portfile added

Portfile of pinpoint 0.1.2

comment:4 Changed 8 years ago by jmroot (Joshua Root)

Keywords: pinpoint removed
Summary: pinpoint 0.1.2NEW: pinpoint 0.1.2
Version: 2.1.2

comment:5 in reply to:  2 Changed 8 years ago by ryandesign (Ryan Schmidt)

Keywords: clutter cairo removed
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Replying to macports@…:

What is the main difference between cairo and cairo-devel? I'm not sure about how to resolve this dependency.

cairo is the latest stable version of cairo. cairo-devel is the latest development version of cairo. Unless this port has very specific cairo version needs, it should be fine to use either of them. But you're right, it's probably fine to just let cairo be an indirect dependency via clutter.

comment:6 Changed 8 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

I committed the port in r101395 with these changes:

  • updated to version 0.1.4
  • removed now-unnecessary patchfile
  • used smaller xz distfile
  • removed the distfiles line because it was the default
  • fixed checksums line (sha256 instead of sha356)
  • fixed license (LGPL-2.1+ instead of GPLv2.1)
  • removed autoconf dependency because it does not appear to be used
  • used branch variable in master_sites
  • used gnome fetchgroup in master_sites
  • fixed livecheck
  • some reformatting

comment:7 Changed 8 years ago by ryandesign (Ryan Schmidt)

The mountainlion buildbot failed to build the port, saying:

checking for pkg-config... no
checking how to run the C preprocessor... /usr/bin/clang -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking for supported compiler flags...  -Wall
checking for the stuff needed to generate PDFs... no
checking for the stuff needed to show media files... no
checking for the stuff needed to put SVGs in PDFs... no
checking for dax... no
checking for DEPS... no
configure: error: in `/opt/local/var/macports/build/_opt_mports_dports_office_pinpoint/pinpoint/work/pinpoint-0.1.4':
configure: error: The pkg-config script could not be found or is too old.  Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full
path to pkg-config.

Fixed by adding pkgconfig build dependency in r101399.

I disabled silent build rules in r101400 to get more detailed logs if the port ever fails to build again.

Note: See TracTickets for help on using tickets.