Opened 6 years ago

Closed 6 years ago

#37423 closed enhancement (fixed)

silo: add +gcc47 variant

Reported by: johnsonsr@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: silo

Description

Add support for building Silo with the MacPorts gcc 4.7 compiler.

Attachments (2)

Portfile-silo.patch (1.1 KB) - added by johnsonsr@… 6 years ago.
Portfile-silo.diff (1.1 KB) - added by johnsonsr@… 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by mf2k (Frank Schima)

It would be nice to add other gcc variants including gcc45 (the current default for Macports scientific ports), gcc46 and gcc48.

comment:2 Changed 6 years ago by johnsonsr@…

It would be nicer if MacPorts had the infrastructure to auto-generate the seven different GCC variants :) . If it's important, I can add it.

comment:3 Changed 6 years ago by ryandesign (Ryan Schmidt)

gcc45 is the default gcc variant we are using in ports that require a MacPorts gcc, so at least gcc45 should be there—assuming there is a reason to build this port with a MacPorts gcc compiler at all?

comment:4 Changed 6 years ago by mf2k (Frank Schima)

When built with the default hdf5 variant, it depends on hdf5-18 which has gcc4x variants. So I assume that silo would need to be built with the same gcc too. So it should match the hdf5-18 port which has variants on gcc44, gcc45, gcc46, and gcc47. I think gcc44 can be skipped though.

Yes, having a gcc portgroup would be nice. But I'm unsure how hard that would be to make for all cases.

Changed 6 years ago by johnsonsr@…

Attachment: Portfile-silo.patch added

Changed 6 years ago by johnsonsr@…

Attachment: Portfile-silo.diff added

comment:5 Changed 6 years ago by johnsonsr@…

I have updated the patch file to include all the GCC variants.

comment:6 Changed 6 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Version: 2.1.2
Note: See TracTickets for help on using tickets.