Opened 11 years ago

Closed 11 years ago

#37471 closed submission (fixed)

NEW: py-stfio

Reported by: neurodroid (Christoph Schmidt-Hieber) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: Cc: neurodroid (Christoph Schmidt-Hieber), flyamer@…, sjm.guzman@…, neurohost@…, janina.kowalski@…, c.wilms@…, vanesalluna@…, doreenmilius@…, sanja.mikulovic@…, helensaad@…, ci42, cooljeanius (Eric Gallager)
Port: py-stfio

Description

py-stfio is a Python module to read common electrophysiology file formats. It's been available in the Debian repositories for quite a while now (http://packages.debian.org/sid/python-stfio). Portfile is available here: https://stimfit.googlecode.com/git/macosx/macports/python/py-stfio/Portfile

Thanks for your consideration.

Change History (24)

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Type: submissionrequest
Version: 2.1.2

comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Type: requestsubmission
Version: 2.1.2

Oh sorry, it is a submission; I initially only saw that there was no attachment in this ticket and overlooked the URL.

Some questions and comments about the port at the URL:

  • "license GPL": Can you indicate the license version(s)? e.g. "GPL-2" or maybe "GPL-3+".
  • "master_sites https://stimfit.googlecode.com/files/ file:///Users/cs/stimfit/build/release/": "master_sites googlecode:stimfit" is preferred; listing a file:/// URL in master_sites doesn't make sense
  • "supported_archs x86_64 i386": for what reason does this software not work on PowerPC?
  • "python.default_version 27" can be omitted because that is the default
  • "configure.args PYTHON=${python.bin}": "configure.python ${python.bin}" is preferred
  • "depends_lib port:swig-python": is it really a library dependency? Usually swig is only used at build time, to build some kind of language bindings.

comment:3 in reply to:  2 Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)

Thanks for your review. All addressed in https://code.google.com/p/stimfit/source/detail?r=a3f9b9be56d8

Replying to ryandesign@…:

Some questions and comments about the port at the URL:

  • "license GPL": Can you indicate the license version(s)? e.g. "GPL-2" or maybe "GPL-3+".

Fixed.

  • "master_sites https://stimfit.googlecode.com/files/ file:///Users/cs/stimfit/build/release/": "master_sites googlecode:stimfit" is preferred; listing a file:/// URL in master_sites doesn't make sense

How neat is that. Fixed.

  • "supported_archs x86_64 i386": for what reason does this software not work on PowerPC?

It hasn't been tested on ppc, and there's good reason to believe that big endianness may cause trouble.

  • "python.default_version 27" can be omitted because that is the default

Fixed.

  • "configure.args PYTHON=${python.bin}": "configure.python ${python.bin}" is preferred

Fixed.

  • "depends_lib port:swig-python": is it really a library dependency? Usually swig is only used at build time, to build some kind of language bindings.

Fixed.

The updated Portfile is available here: https://stimfit.googlecode.com/git/macosx/macports/python/py-stfio/Portfile

comment:4 Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)

Cc: christsc@… added

Cc Me!

comment:5 Changed 11 years ago by flyamer@…

Cc: flyamer@… added

Cc Me!

comment:6 Changed 11 years ago by sjm.guzman@…

Cc: sjm.guzman@… added

Cc Me!

comment:7 Changed 11 years ago by sjm.guzman@…

Cc: sjm.guzman@… removed

Cc Me!

comment:8 Changed 11 years ago by sjm.guzman@…

Cc: sjm.guzman@… added

Cc Me!

comment:9 Changed 11 years ago by neurohost@…

Cc: neurohost@… added

Cc Me!

comment:10 Changed 11 years ago by neurohost@…

Cc: neurohost@… removed

Cc Me!

comment:11 Changed 11 years ago by neurohost@…

Cc: neurohost@… added

Cc Me!

comment:12 Changed 11 years ago by janina.kowalski@…

Cc: janina.kowalski@… added

Cc Me!

comment:13 Changed 11 years ago by c.wilms@…

Cc: c.wilms@… added

Cc Me!

comment:14 Changed 11 years ago by vanesalluna@…

Cc: vanesalluna@… added

Cc Me!

comment:15 Changed 11 years ago by doreenmilius@…

Cc: doreenmilius@… added

Cc Me!

comment:16 Changed 11 years ago by sanja.mikulovic@…

Cc: sanja.mikulovic@… added

Cc Me!

comment:17 Changed 11 years ago by helensaad@…

Cc: helensaad@… added

Cc Me!

comment:18 Changed 11 years ago by ci42

Some remarks:

  • as the software is licensed under the GPL the port should include a copy in ${prefix}/share/doc/py-stfio/ (see https://www.gnu.org/licenses/gpl-faq.html#WhyMustIInclude).
  • there are no .pyc files included. Most py-* ports include them because they can't be generated afterwards (the installation directory is typically read-only for ordinary users).
  • the debian packages includes hdf5tools.py. The port does not (I don't know if this is revelvant).

comment:19 Changed 11 years ago by ci42

Cc: ciserlohn@… added

Cc Me!

comment:20 Changed 11 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:21 in reply to:  18 ; Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)

Thanks for your review.

Replying to ciserlohn@…:

Some remarks:

Fixed in r45f538cbfddc.

  • there are no .pyc files included. Most py-* ports include them because they can't be generated afterwards (the installation directory is typically read-only for ordinary users).

Fixed in r609ada02fd6a. This is useful for other platforms as well.

  • the debian packages includes hdf5tools.py. The port does not (I don't know if this is revelvant).

hdf5tools.py should not be part of the latest versions of py-stfio.

comment:22 in reply to:  21 ; Changed 11 years ago by ci42

Replying to christsc@…:

Thanks for your review.

Replying to ciserlohn@…:

Some remarks:

Fixed in r45f538cbfddc.

The port now installs ${prefix}/share/doc/py27-stfio/copyright which is good, but it does not include the full text of the GPL:

On Debian systems, the full text of the GNU General Public
License version 2 can be found in the file
`/usr/share/common-licenses/GPL-2'.

We're not on debian so the aforementioned file does not exists. Please include a full text version of the GPL.

Apart from that I think the port is ready for inclusion.

comment:23 in reply to:  22 Changed 11 years ago by neurodroid (Christoph Schmidt-Hieber)

Replying to ciserlohn@…:

Replying to christsc@…:

Thanks for your review.

Replying to ciserlohn@…:

Some remarks:

Fixed in r45f538cbfddc.

The port now installs ${prefix}/share/doc/py27-stfio/copyright which is good, but it does not include the full text of the GPL:

On Debian systems, the full text of the GNU General Public
License version 2 can be found in the file
`/usr/share/common-licenses/GPL-2'.

We're not on debian so the aforementioned file does not exists. Please include a full text version of the GPL.

Fixed in r948c6eac5c8a. This also addresses the remaining comment in ticket #33575.

Apart from that I think the port is ready for inclusion.

Thanks

comment:24 Changed 11 years ago by ci42

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.