Opened 11 years ago

Closed 8 years ago

#37536 closed update (fixed)

NGSPICE 25 Release

Reported by: nicolati@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: holger.waechtler@…, anddam (Andrea D'Amore)
Port: ngspice

Description

Hello everybody, I'm from NGSPICE team. I wanted to add the new NGSPICE 25 Release in MacPorts OFFICIALLY. So I can maintain it. How can I proceed ? Do I have to diff the already existing version 24 or can I submit a totally new port ? In this case, is the PortFile Creation enough ? I have to learn this new interesting system! :)

Thank you, Francesco

Attachments (4)

Portfile (2.5 KB) - added by nicolati@… 11 years ago.
NGSPICE 25 Release Portfile
Portfile-rrdtool.diff (6.7 KB) - added by nicolati@… 11 years ago.
Portfile Diff against NGSPICE 24
ngspice-26-Portfile.diff (3.0 KB) - added by holger.waechtler@… 10 years ago.
Portfile diff for ngspice-26, incorporating requested changes
Portfile.2 (2.5 KB) - added by holger.waechtler@… 10 years ago.
Portfile for ngspice-26, incorporating requested changes

Download all attachments as: .zip

Change History (14)

Changed 11 years ago by nicolati@…

Attachment: Portfile added

NGSPICE 25 Release Portfile

comment:1 Changed 11 years ago by mf2k (Frank Schima)

Type: submissionupdate
Version: 2.1.2

Since we already have a port for ngspice, please attach a unified diff of the existing portfile instead.

comment:2 Changed 11 years ago by nicolati@…

Ok! Just let me understand if I have to include the dependency from xorg-libXaw, because I personally use Xquartz.

Thank you, Francesco

comment:3 Changed 11 years ago by jmroot (Joshua Root)

Yes, we want to use our own xorg libs.

comment:4 Changed 11 years ago by nicolati@…

Ok for that, but I wrote incorrectly. I meant xorg-server or Xquartz should be added as dependencies or they are supposed to be present some way?

Fra

Changed 11 years ago by nicolati@…

Attachment: Portfile-rrdtool.diff added

Portfile Diff against NGSPICE 24

comment:5 Changed 10 years ago by holger.waechtler@…

The dependency should be added, otherwise the user has to install xorg manually (needed for ngspice+plot).

comment:6 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: holger.waechtler@… added
Keywords: haspatch added

Has duplicate #43507 which notes version 26 is available in the meantime.

A dependency on xorg-server should not be added. It's up to the user to install whatever X server they want to use (or even to use an X server on another machine). Dependencies on individual X libraries the port links with should be added, of course.

Why was configure.compiler set to "gcc"? That's almost always wrong, and contrary to the intentions expressed in UsingTheRightCompiler. Usually the compiler should be left at the default value. If the default compiler (clang, in current versions of OS X) does not compile this program, the program's code should be fixed. If that's not possible, clangs can be blacklisted by using "compiler.blacklist *clang*", however if this program uses C++ code that will be problematic for users on Mavericks or later; see wiki:FAQ#libcpp.

"system" should not be used when equivalent MacPorts tcl commands exist. In this case, instead of using "system" to run "cp -r", use the MacPorts tcl "copy" command.

Changed 10 years ago by holger.waechtler@…

Attachment: ngspice-26-Portfile.diff added

Portfile diff for ngspice-26, incorporating requested changes

Changed 10 years ago by holger.waechtler@…

Attachment: Portfile.2 added

Portfile for ngspice-26, incorporating requested changes

comment:7 Changed 10 years ago by holger.waechtler@…

Dear Ryan,

please see the updated patch and port file.

Sincerely,

comment:8 Changed 10 years ago by mf2k (Frank Schima)

Thanks! Committed in r120515 with the following changes:

  • Did not edit the $Id: line
  • Modified the description to no longer say that Cider is not installed because of the --enable-cider configure argument.

comment:9 Changed 9 years ago by anddam (Andrea D'Amore)

Cc: and.damore@… added

The ticket can be closed since ngspice port is already at version 26 but is the OP still interested in being maintainer of the port?

comment:10 Changed 8 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

No response from OP so closing the ticket as is, but if anyone would like to take maintainership of this port please file a ticket saying so and we'll make it happen.

Note: See TracTickets for help on using tickets.