Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#37580 closed update (fixed)

pdftk @1.44: update to 2.02

Reported by: tenomoto (Takeshi Enomoto) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: clemens.brunner@…, cooljeanius (Eric Gallager), florian@…, maehne (Torsten Maehne), cielartisan@…, anddam (Andrea D'Amore), petrrr
Port: pdftk

Description

See the patch.

Attachments (4)

Portfile.diff (897 bytes) - added by tenomoto (Takeshi Enomoto) 7 years ago.
pdftk-2.01.diff (3.1 KB) - added by ryandesign (Ryan Schmidt) 6 years ago.
pdftk-2.02.diff (3.0 KB) - added by florian@… 6 years ago.
Portfile patch
patch-Makefile.OSX-10.6.diff (1.4 KB) - added by florian@… 6 years ago.
Makefile patch

Download all attachments as: .zip

Change History (23)

Changed 7 years ago by tenomoto (Takeshi Enomoto)

Attachment: Portfile.diff added

comment:1 Changed 7 years ago by petrrr

Cc: Peter.Danecek@… added

Cc Me!

comment:2 Changed 7 years ago by petrrr

Cc: Peter.Danecek@… removed

Cc Me!

comment:3 Changed 7 years ago by petrrr

Cc: Peter.Danecek@… added

Cc Me!

comment:4 Changed 6 years ago by clemens.brunner@…

Version 2.01 was released on June 5 2013.

comment:5 Changed 6 years ago by ryandesign (Ryan Schmidt)

Cc: clemens.brunner@… added
Keywords: haspatch added
Status: newassigned
Summary: pdftk @1.44: update to 1.45 availablepdftk @1.44: update to 2.01

I had problems updating the port to 1.45 (it would not build). Then I had problems on some systems getting the existing 1.44 to build anymore, which I blamed on changes to the gcc ports that I had hoped would get ironed out. Months later that has not yet occurred, so I have to accept that those systems (Leopard and Tiger) will unfortunately no longer be able to use pdftk as a result.

The attached patch updates the port to 2.01; removes the gcc42 variant (#34275) since it had previously only been needed on older systems and we want to remove the gcc42 port (#33919); removes a check for build problems that affected gcc42 (#13553); defaults to gcc47 as other ports now do; and prevents installation on Leopard and earlier because depending on the system I tested the build either fills up the disk with swap files and runs out of memory on the first gcj invocation (PowerPC) or every gcj invocation crashes (Intel).

I am not yet committing the patch because I have not yet tested whether the gcc45 and gcc47 variants both work on Snow Leopard, Lion and Mountain Lion. If you would like to test the patch and let me know your experiences on your system, that would be helpful.

Changed 6 years ago by ryandesign (Ryan Schmidt)

Attachment: pdftk-2.01.diff added

comment:6 Changed 6 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

comment:7 in reply to:  5 Changed 6 years ago by florian@…

I am not yet committing the patch because I have not yet tested whether the gcc45 and gcc47 variants both work on Snow Leopard, Lion and Mountain Lion. If you would like to test the patch and let me know your experiences on your system, that would be helpful.

I tried 2.02 (not 2.01) with gcc47 on Snow Leopard. It works. I'll attach a modified Portfile patch as well as patch-Makefile.OSX-10.6.diff. Note that linking against libz and libiconv is not necessary. Cheers

Changed 6 years ago by florian@…

Attachment: pdftk-2.02.diff added

Portfile patch

Changed 6 years ago by florian@…

Makefile patch

comment:8 Changed 6 years ago by florian@…

Cc: florian@… added

Cc Me!

comment:9 Changed 6 years ago by maehne (Torsten Maehne)

Cc: Torsten.Maehne@… added

Cc Me!

comment:10 Changed 5 years ago by petrrr

I am testing version 2.02 with as slightly modified Portfile. It installs without problems. Is there a good way to test stability?

I also tested with gcc48 and gcc49, but both fail to compile, with the same issue as documented in #22066. Maybe similar fix needs to be applied to other gcc versions. Or, I may be even better to provide separate port(s) to provide ecj1?

comment:11 Changed 5 years ago by cielartisan@…

Cc: cielartisan@… added

Cc Me!

comment:12 Changed 5 years ago by anddam (Andrea D'Amore)

Cc: and.damore@… added

Possibly good to be worked on since r127365, see ticket:43978#comment:50.

Last edited 5 years ago by anddam (Andrea D'Amore) (previous) (diff)

comment:13 Changed 5 years ago by petrrr

Cc: petr@… added

Cc Me!

comment:14 Changed 5 years ago by petrrr

Cc: Peter.Danecek@… removed
Version: 2.1.2

comment:15 Changed 5 years ago by petrrr

Summary: pdftk @1.44: update to 2.01pdftk @1.44: update to 2.02

comment:16 Changed 5 years ago by petrrr

I performed some tests on my OS X 10.8 machine:

  • pdftk @2.02_0+gcc47 -- seems to work fine
  • pdftk @2.02_0+gcc45 -- builds, but is broken. Gives a Segmentation fault when used (help shows up)

Same pattern for the old current version:

  • pdftk @1.44_0+gcc47 -- works
  • pdftk @1.44_0+gcc45 -- broken

So it seems to be the compiler which generates broken code on my machine. So if there is now good point in using gcc45, I would propose to smoke the compiler variants completely and use only gcc47, at least for the moment as long no newer compiler supports it.

comment:17 Changed 5 years ago by petrrr

One more thing: The homepage in the Portfile redirects to https://www.pdflabs.com/tools/pdftk-the-pdf-toolkit/

comment:18 Changed 5 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

I've updated pdftk to 2.02 and fixed the homepage in r129035.

I tested with the gcc47 variant on Yosemite and Snow Leopard; my test worked on both. I didn't try the gcc45 variant and didn't see your remark above about it not producing a working program. Assuming using the gcc47 variant works everywhere, I may delete the gcc45 variant later. Right now, I cannot build gcc on OS X versions earlier than 10.6 so I'm waiting until I can do that and test on those systems.

comment:19 Changed 5 years ago by tenomoto (Takeshi Enomoto)

Ryan, thanks for the update! Takeshi

Note: See TracTickets for help on using tickets.