Opened 11 years ago

Closed 11 years ago

#37771 closed defect (fixed)

xdm @1.1.11_0: error: security/pam_appl.h: No such file or directory

Reported by: johanmattssonm (Johan Mattsson) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: tiger leopard haspatch Cc: jeremyhu (Jeremy Huddleston Sequoia)
Port: xdm

Description (last modified by ryandesign (Ryan Carsten Schmidt))

xdm fails to build;

:info:build In file included from chooser.c:63:
:info:build ../include/dm.h:108:33: error: security/pam_appl.h: No such file or directory
:info:build In file included from chooser.c:63:
:info:build ../include/dm.h:427: error: syntax error before ‘*’ token
:info:build ../include/dm.h:427: warning: type defaults to ‘int’ in declaration of ‘thepamhp’
:info:build ../include/dm.h:427: warning: data definition has no type or storage class
:info:build ../include/dm.h:428: error: syntax error before ‘*’ token
:info:build ../include/dm.h:428: warning: type defaults to ‘int’ in declaration of ‘thepamh’
:info:build ../include/dm.h:428: warning: data definition has no type or storage class

Attachments (3)

main.log (21.8 KB) - added by johanmattssonm (Johan Mattsson) 11 years ago.
patch-pam_appl.diff (585 bytes) - added by ryandesign (Ryan Carsten Schmidt) 11 years ago.
Portfile.diff (488 bytes) - added by ryandesign (Ryan Carsten Schmidt) 11 years ago.

Download all attachments as: .zip

Change History (16)

Changed 11 years ago by johanmattssonm (Johan Mattsson)

Attachment: main.log added

comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Description: modified (diff)
Owner: changed from macports-tickets@… to jeremyhu@…
Summary: xdm fails to buildxdm @1.1.11_0: error: security/pam_appl.h: No such file or directory

comment:2 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: worksforme
Status: newclosed

You should have it at /usr/include/security/pam_appl.h ... I see it on my SL, Lion, and ML boxes. Make sure you've got a sane build environment.

comment:3 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

(ie: Install XCode and the command line tools)

comment:4 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: worksforme
Status: closedreopened

Oh, I see in main.log that you're using Leopard. You should really call that out in your bug report.

comment:5 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Owner: changed from jeremyhu@… to ryandesign@…
Status: reopenednew

Over to ryan to look at since he's got Leopard boxes still.

comment:6 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Cc: jeremyhu@… added

Cc Me!

comment:7 in reply to:  2 Changed 11 years ago by johanmattssonm (Johan Mattsson)

Replying to jeremyhu@…:

You should have it at /usr/include/security/pam_appl.h ... I see it on my SL, Lion, and ML boxes. Make sure you've got a sane build environment.

I do have pam_appl.h:

m83-180-167-138:bin johanmattsson$ ls /usr/include/pam/pam_appl.h 
/usr/include/pam/pam_appl.h

I don't know what else that might be needed.

Cheers

comment:8 Changed 11 years ago by johanmattssonm (Johan Mattsson)

I disabled pam support in the config file. Xdm builds now,

comment:9 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

xpm was already successfully installed on my Leopard i386 machine. I just rebuilt it to verify it still builds. I haven't yet compared the failed log attached here with mine.

comment:10 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

xpm != xdm

comment:11 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Indeed! Ok, xdm fails for me as it does for the reporter. The project seems hardcoded to #include <security/pam_appl.h>. I'll check if changing that to <pam/pam_appl.h> is all that's needed for Leopard.

comment:12 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: tiger leopard haspatch added

Yes that seems to work. This patch is messy because it must be conditionally applied only on Leopard and lower. Is that ok or should we rewrite it to use some #if logic so that it can be applied always?

Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: patch-pam_appl.diff added

Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: Portfile.diff added

comment:13 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.