Opened 11 years ago

Closed 5 years ago

#37773 closed update (fixed)

vislcg3 update to 0.9.8.8406

Reported by: tino.didriksen@… Owned by: TinoDidriksen
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: p.ixiemotion@…, chrstphrchvz (Christopher Chavez)
Port: vislcg3

Description

1) p.ixiemotion has ceased updating this as he no longer uses OS X, so I will take over maintenance. CC'ed to get confirmation.

2) I would like to claim FreeBSD support, but port:boost is called boost-lib in FreeBSD, so not sure that would work smoothly.

3) CMake param -DCMAKE_INSTALL_PREFIX=/opt/local I am not sure is needed, since I don't know if you globally set envvar CMAKE_INSTALL_PREFIX when building packages.

Attachments (1)

Portfile-vislcg3.diff (1.8 KB) - added by tino.didriksen@… 11 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by p.ixiemotion@…

confirmed :)

comment:2 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)

  • the revision should drop to zero
  • hardcoding /opt/local is not ok; use ${prefix}
  • we do not globally set an envvar CMAKE_INSTALL_PREFIX. We do have a cmake portgroup which you can use which does set that in configure.args; not sure if that would help you here.
  • in what way is port:boost "called" boost-lib in FreeBSD? If you mean that's its name in the FreeBSD ports system, then that's totally irrelevant for MacPorts

Changed 11 years ago by tino.didriksen@…

Attachment: Portfile-vislcg3.diff added

comment:3 Changed 11 years ago by tino.didriksen@…

Alrighty, changes adopted, new patch attached.

comment:4 Changed 9 years ago by unhammer+dill@…

ryandesign: Was the new patch OK? It's been a while, and we keep having to tell people not to install from macports since it's out-of-date. (I think it'd be better if it weren't in macports at all until it's kept up-to-date.)

comment:5 Changed 9 years ago by mf2k (Frank Schima)

Sorry, this one clearly got forgotten. Some comments:

  • Is 0.9.8.8406 still the latest release version?
  • Remove the redundant depends_build cmake line. The cmake portgroup already adds this.
  • Use depends_lib-append to not overwrite any portgroup dependencies. This is best practice in this case because the cmake portgroup does not currently have any library dependencies.

comment:6 in reply to:  5 Changed 9 years ago by tino.didriksen@…

Replying to mf2k@…:

  • Is 0.9.8.8406 still the latest release version?

No, that's ancient, and it changes often. If it could pull directly from svn or git, that'd be best - the master branch has been the recommended version since forever.

comment:7 Changed 9 years ago by mf2k (Frank Schima)

We don't do it that way because it does not work with the buildbots and it does not allow for a repeatable build. I.e. it is not supportable.

comment:8 Changed 5 years ago by chrstphrchvz (Christopher Chavez)

Cc: chrstphrchvz added

comment:9 Changed 5 years ago by chrstphrchvz (Christopher Chavez)

In 01451d5b9f9c9e63c3909de47814fef6815dc1e8/macports-ports (master):

vislcg3: update maintainer

See: #37773

comment:10 Changed 5 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to TinoDidriksen
Status: newassigned
Version: 2.1.2

comment:11 Changed 5 years ago by Tino Didriksen <mail@…>

Resolution: fixed
Status: assignedclosed

In 2b715b9bbc0fec83e78d84dabf85096f4ca8eb77/macports-ports (master):

vislcg3: update to version 1.3.0

  • update to version 1.3.0
  • use github and cmake helpers
  • explicitly state GPL-3+ license
  • require at least C++17

Closes: #37773

Note: See TracTickets for help on using tickets.