Opened 11 years ago

Closed 11 years ago

#37812 closed defect (fixed)

pioneers has weird behavior contingent on configure.compiler

Reported by: jeremyhu (Jeremy Huddleston Sequoia) Owned by: nerdling (Jeremy Lavergne)
Priority: Normal Milestone:
Component: ports Version: 2.1.2
Keywords: Cc: jweede@…
Port: pioneers

Description

The pioneers portfile has: 

if {{$configure.compiler} != "gcc-4.2"} {
    patchfiles          patch-common-notifying-string.c.diff
}
...
post-configure {
    if {${configure.compiler} != "gcc-4.2"} {
        reinplace {s| -Wl,-z,relro -Wl,-z,now||} ${worksrcpath}/Makefile
        reinplace s|-Wl,--as-needed|| ${worksrcpath}/Makefile
    }
}

It doesn't really make sense to me that this would be done only in cases where gcc-4.2 is not being used. What's the rationale here? We should probably be doing something different.

Also, the first patch should just always be applied.

Change History (2)

comment:1 Changed 11 years ago by jmroot (Joshua Root)

Cc: jweede@… added

comment:2 Changed 11 years ago by jeremyhu (Jeremy Huddleston Sequoia)

Resolution: → fixed
Status: new → closed

r109060

Note: See TracTickets for help on using tickets.