Changes between Initial Version and Version 1 of Ticket #37844, comment 3


Ignore:
Timestamp:
Jan 31, 2013, 1:50:20 PM (11 years ago)
Author:
dw@…
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #37844, comment 3

    initial v1  
    1010
    1111>  * You're hardcoding the list of architectures to use in the universal variant, and not setting any architecture when not using the universal variant; you need to always set architectures, and use the list of architectures the user requested. The [get_canonical_archflags] procedure is useful for this. Ensure you define at least an empty universal variant ("variant universal {}") before invoking [get_canonical_archflags] (and in this portfile I don't think you'll need more than an empty universal variant).
     12
    1213>  * In the universal variant, the second build.env statement overrides the first. If you want to append to the environment rather than overwriting it, use build.env-append, but note that you can set multiple environment variables in a single build.env invocation, which is usually preferable.
     14
     15Now there is a single build.env-append statement and the universal variant is defined.
    1316
    1417
    1518>  * The snappy variant only adds a dependency; it does nothing to ensure that snappy will ''not'' be used if the snappy variant is ''not'' selected. Is there a reason why snappy needs to be a variant? Couldn't snappy support just be enabled all the time?
    1619
    17 In this case, leveldb's build_detect_platform notices the libraries and enables them, so all required is to ensure they exist. I concur that just removing the variant makes more sense: snappy is a motivating feature of LevelDB and it can still be disabled at runtime. The alternative is battling the simplistic build_detect_platform into ignoring it.
     20In this case, leveldb's `build_detect_platform` notices the libraries and enables them, so all required is to ensure they exist. I concur that just removing the variant makes more sense: snappy is a motivating feature of LevelDB and it can still be disabled at runtime. The alternative is battling the simplistic `build_detect_platform` into ignoring it.
    1821
    1922