lcms, lcms2: fails to compile against jpeg 9

[blair (Blair Zajac)]

Recompiling jpeg's dependent ports, got this failure:

make[1]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_lcms2/lcms2/work/lcms2-2.4/utils/jpgicc'
/usr/bin/clang -DPACKAGE_NAME=\"lcms2\" -DPACKAGE_TARNAME=\"lcms2\" -DPACKAGE_VERSION=\"2.4\" -DPACKAGE_STRING=\"lcms2\ 2.4\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHasJPEG=1 -DHasZLIB=1 -DHasTIFF=1 -DHAVE_TIFFCONF_H=1 -I.  -I../../include -I../../include -I../../utils/common -I../../utils/common -I/opt/local/include  -pipe -O2 -arch x86_64 -MT jpgicc.o -MD -MP -MF .deps/jpgicc.Tpo -c -o jpgicc.o jpgicc.c
In file included from jpgicc.c:30:
In file included from /opt/local/include/jpeglib.h:27:
/opt/local/include/jmorecfg.h:263:16: error: expected '}'
typedef enum { FALSE = 0, TRUE = 1 } boolean;
               ^
../../include/lcms2.h:227:22: note: expanded from macro 'FALSE'
#       define FALSE 0
                     ^
/opt/local/include/jmorecfg.h:263:14: note: to match this '{'
typedef enum { FALSE = 0, TRUE = 1 } boolean;
             ^
jpgicc.c:1094:42: warning: data argument not used by format string [-Wformat-extra-args]
                     SW, SW, SW, SW, SW, SW);
                                         ^
1 warning and 1 error generated.
make[1]: *** [jpgicc.o] Error 1

[blair (Blair Zajac)]

BTW, this is on 10.7.

[ryandesign (Ryan Carsten Schmidt)]

I get the same on 10.5 and 10.8, and also with lcms.

[ryandesign (Ryan Carsten Schmidt)]

Do lcms/lcms2 need a fix like tiff got in r102823?

wxWidgets is also affected; #37983

povray looks to be affected; #37985

[crossd@…]

Replying to ryandesign@…:

Do lcms/lcms2 need a fix like tiff got in r102823?

wxWidgets is also affected; #37983

povray looks to be affected; #37985

openmotif is also affected.

[larryv (Lawrence Velázquez)]

Has duplicates #37986 and #37987.

[sewebster@…]

Cc Me!

[irony42@…]

Replying to crossd@…:

Replying to ryandesign@…:

Do lcms/lcms2 need a fix like tiff got in r102823?

wxWidgets is also affected; #37983

povray looks to be affected; #37985

openmotif is also affected.

libmng and poppler are also affected.

[ryandesign (Ryan Carsten Schmidt)]

Replying to crossd@…:

openmotif is also affected.

Please file individual tickets for each separate port that itself fails to build with jpeg 9, since at this point I'm assuming an individual fix will be needed for each affected port.

openmotif: #37989

gdal: #37988

Replying to irony42@…:

libmng and poppler are also affected.

libmng depends on lcms and poppler depends on lcms2, so it's hard to know whether libmng and poppler themselves fail to build with jpeg 9 until we resolve the issues with lcms and lcms2.

[irony42@…]

Replying to ryandesign@…:

Replying to irony42@…:

libmng and poppler are also affected.

libmng depends on lcms and poppler depends on lcms2, so it's hard to know whether libmng and poppler themselves fail to build with jpeg 9 until we resolve the issues with lcms and lcms2.

Right. On second glance, it looks like just poppler has an independent issue... we'll see.

[pingemi@…]

I thought it odd that JPEG 9 assumes if there's no boolean type, then TRUE and FALSE aren't defined. So in /opt/local/include/jmorecfg.h I replaced:

typedef enum { FALSE = 0, TRUE = 1 } boolean;

with:

#ifndef TRUE
#ifndef FALSE
typedef enum { FALSE = 0, TRUE = 1 } boolean;
#else
typedef int boolean;
#endif
#else
typedef int boolean;
#endif

seems to work fine.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #37991.

[janusofzeal@…]

Cc Me!

[ryandesign (Ryan Carsten Schmidt)]

Duplicate of #37984.

[ryandesign (Ryan Carsten Schmidt)]

Has duplicate #37993.