Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#38083 closed enhancement (fixed)

gtk3: use require_active_variants like gtk2 does

Reported by: ryandesign (Ryan Schmidt) Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch Cc:
Port: gtk3

Description

I fixed gtk2 to use require_active_variants. Then I wanted to make gtk3 do the same. Then I realized gtk3 was already using require_active_variants but slightly differently.

This patch updates gtk3 to do it the way gtk2 now does.

There is a slight change in behavior: previously, gtk3+quartz could not be installed if pango+quartz+x11 was installed; it required pango+quartz (without +x11). Was this restriction necessary? If not, we should remove it, as in the attached patch. If the restriction really was necessary, I'm guessing we should add it to gtk2 as well.

There was no corresponding restriction for +x11. The port already allowed gtk3+x11 to be installed if pango+quartz+x11 was installed, and this patch doesn't change that.

Attachments (1)

gtk3-active_variants.diff (1.4 KB) - added by ryandesign (Ryan Schmidt) 8 years ago.
proposed patch

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by ryandesign (Ryan Schmidt)

Attachment: gtk3-active_variants.diff added

proposed patch

comment:1 Changed 8 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

Thanks, I just wasn't aware pango's +x11 and +quartz don't conflict.

r103160.

comment:2 Changed 8 years ago by ryandesign (Ryan Schmidt)

I forgot that for awhile too :P

Note: See TracTickets for help on using tickets.