Attachments (2)

graphviz-deps.diff (15.0 KB) - added by larryv (Lawrence Velázquez) 6 years ago.
add explicit graphviz dependencies
graphviz-deps.2.diff (15.0 KB) - added by larryv (Lawrence Velázquez) 6 years ago.
add explicit graphviz dependencies

Download all attachments as: .zip

Change History (14)

comment:1 Changed 6 years ago by cooljeanius (Eric Gallager)

From the mailing lists:

Perhaps a default variant (+diagrams)?

^ I vote for that option.

Last edited 6 years ago by cooljeanius (Eric Gallager) (previous) (diff)

comment:2 Changed 6 years ago by jmroot (Joshua Root)

A default variant would mean that everyone gets graphviz pulled in unless they specifically know to disable the variant, which seems like it defeats the purpose of the change. Also, wouldn't the variant do nothing but add a dependency, and not change the installed files at all? That's not really what variants should be used for.

comment:3 Changed 6 years ago by larryv (Lawrence Velázquez)

Cc: afb@… andre.anjos@… cal@… devans@… eborisch@… jeremyhu@… laurent.el-shafey@… marin.saric@… michaelld@… n3npq@… ryandesign@… added
Port: awesome bob eigen3 fish gerbil gnome-vfsmm gnuradio goocanvasmm gr-osmosdr kdeaddons3 kdebase3 kdelibs3 libexif libgphoto2 libspectre ogre openni rpm rpm45 rpm50 rpm51 rpm52 rpm53 rpm54 sofia-sip xorg-libxcb added

As far as I can tell, these are the ports that use Graphviz (or can autodetect and use it) while generating Doxygen documentation. I’d like to add an explicit path:bin/dot:graphviz dependency to each one; please let me know if this is incorrect for any of them.

Changed 6 years ago by larryv (Lawrence Velázquez)

Attachment: graphviz-deps.diff added

add explicit graphviz dependencies

Changed 6 years ago by larryv (Lawrence Velázquez)

Attachment: graphviz-deps.2.diff added

add explicit graphviz dependencies

comment:4 Changed 6 years ago by larryv (Lawrence Velázquez)

Oops, accidentally uploaded the same diff twice.

comment:5 Changed 6 years ago by eborisch (Eric A. Borisch)

Implemented for eigen3 in r103748

comment:6 Changed 6 years ago by michaelld (Michael Dickens)

gnuradio and gr-osmosdr done in r103754 and r103755.

comment:7 Changed 6 years ago by larryv (Lawrence Velázquez)

I just committed the {no,open}maintainer ones: sofia-sip (r103760), libgphoto2 (r103761), gnome-vfsmm (r103762), goocanvasmm (r103763), libexif (r103764), awesome (r103765), fish (r103766), kdebase3 (r103767), kdeaddons3 (r103768), kdelibs3 (r103769), openni (r103770), libspectre (r103771), gerbil (r103772), xorg-libxcb (r103773).

comment:8 Changed 6 years ago by neverpanic (Clemens Lang)

Sorry, I didn't even realize one of my ports was affected. I don't care whether gerbil actually has graphs in its documentation and I wouldn't mind dropping the dependency there, too. Since you added it now, let's just keep it that way for now.

comment:9 Changed 6 years ago by andre.dos.anjos@…

A patch for the bob port has been submitted at (#38325). It addresses this request and an upgrade to version 1.1.3 at the same time.

Last edited 6 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:10 Changed 6 years ago by larryv (Lawrence Velázquez)

Committed ogre (r104110) and rpm{,45,50,51,52,53,54} (r104111).

comment:11 Changed 6 years ago by larryv (Lawrence Velázquez)

Resolution: fixed
Status: newclosed

Moved the graphviz dependency to doxygen’s +doc variant in r104112.

comment:12 Changed 6 years ago by cooljeanius (Eric Gallager)

Cc: egall@… added

Cc Me!

Note: See TracTickets for help on using tickets.