Opened 7 years ago

Closed 7 years ago

#38252 closed update (fixed)

ola @0.8.28 new upstream release

Reported by: nomis52@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: haspatch maintainer Cc: p3k (Tobi Schäfer), othiman@…
Port: ola

Description

Update to reflect the new upstream release. This also adds the OSC variant and enables it by default. (OSC was included from 0.8.26).

Attachments (2)

Portfile-ola.diff (1.6 KB) - added by nomis52@… 7 years ago.
Portfile.ola.diff (1.6 KB) - added by nomis52@… 7 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

The osc variant is insufficient as written. All it does is add a dependency, but it does nothing to ensure that the dependency will not be used if the variant is not selected.

Changed 7 years ago by nomis52@…

Attachment: Portfile-ola.diff added

comment:2 Changed 7 years ago by nomis52@…

You're right. I've updated the file.

comment:3 Changed 7 years ago by othiman@…

Cc: othiman@… added

Cc Me!

comment:4 Changed 7 years ago by nomis52@…

ping

comment:5 in reply to:  4 Changed 7 years ago by ci42

Replying to nomis52@…:

ping

Building ola with clang (clang-425.0.27) fails::

In file included from DmxTriDevice.cpp:24:
../../plugins/usbpro/DmxTriDevice.h:84:19: error: private field 'm_device' is not used [-Werror,-Wunused-private-field]
    DmxTriDevice *m_device;
                  ^
1 error generated.

It works with llvm-gcc, so you should either blacklist clang or better fix the build issue with clang.

comment:6 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… added

Cc Me!

Changed 7 years ago by nomis52@…

Attachment: Portfile.ola.diff added

comment:7 Changed 7 years ago by nomis52@…

I've attached a new diff to pick up release 0.8.28. This fixes the build issues.

comment:8 Changed 7 years ago by ryandesign (Ryan Schmidt)

Cc: ryandesign@… removed
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned
Summary: ola @0.8.27 new upstream releaseola @0.8.28 new upstream release

comment:9 Changed 7 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.