#38267 closed defect (fixed)
v8 @3.17.6 +universal needs its configure.universal_args nuked
| Reported by: | cooljeanius (Eric Gallager) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.3 |
| Keywords: | haspatch | Cc: | frodwith@…, neverpanic (Clemens Lang) |
| Port: | v8 |
Description
Its configure script doesn't recognize the --disable-dependency-tracking flag.
Attachments (1)
Change History (6)
Changed 11 years ago by cooljeanius (Eric Gallager)
| Attachment: | Portfile.diff added |
|---|
comment:1 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Please just write:
configure.universal_args-delete --disable-dependency-tracking
like other ports do. It doesn't need to go inside the universal variant; I don't think any other ports do that.
comment:2 follow-up: 3 Changed 11 years ago by neverpanic (Clemens Lang)
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed in r103654. What's the benefit of this flag anyway? Should we remove it in base?
comment:3 follow-up: 4 Changed 11 years ago by larryv (Lawrence Velázquez)
Replying to cal@…:
What's the benefit of this flag anyway?
http://www.gnu.org/software/automake/manual/html_node/Dependency-Tracking.html
comment:4 follow-up: 5 Changed 11 years ago by cooljeanius (Eric Gallager)
Replying to larryv@…:
Replying to cal@…:
What's the benefit of this flag anyway? Should we remove it in base?
http://www.gnu.org/software/automake/manual/html_node/Dependency-Tracking.html
So in other words we could remove it from everything that doesn't use automake?
comment:5 Changed 11 years ago by larryv (Lawrence Velázquez)
Replying to egall@…:
So in other words we could remove it from everything that doesn't use
automake?
No. The flag is necessary for universal builds because Clang and Apple’s GCC cannot automatically generate dependency information (-M) when targeting multiple architectures. I presume that the configure scripts that don’t accept the flag have dependency generation disabled by default or handle this in some other way.
In my experience, most configure scripts that don’t accept the flag just ignore it. Given that there’s no good way to determine whether a particular build system requires the flag’s presence or absence, I don’t see how we could deal with it in base. And since only 103 out of 9126 portfiles currently mention the flag at all, I don’t see why we should bother.
diff to apply to v8's portfile