#38317 closed update (fixed)
silo: upgrade to 4.9
| Reported by: | kurtjaeke@… | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | silo |
Description
Please upgrade port silo to version 4.9.
Changes:
- when depending on hdf5, also depend on szip
- --disable-qt does not exist anymore, disable browser and silex instead (which use Qt)
Attachments (2)
Change History (10)
Changed 11 years ago by kurtjaeke@…
comment:1 Changed 11 years ago by mf2k (Frank Schima)
| Version: | 2.1.3 |
|---|
The revision line needs to be removed.
comment:2 follow-up: 3 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
Are you certain that the szip dependency should be added in the +hdf5 variant? Does silo itself require szip functions, or are they only used via hdf5-18's interface to them? hdf5-18 can be compiled with or without szip support, via its +szip variant, and the default is off. Can we leave it up to the hdf5-18 port to be in charge of whether szip is used, or does silo really require hdf5-18 with szip support? If the latter, we might want to use the active_variants portgroup to do that.
comment:3 Changed 11 years ago by kurtjaeke@…
The source code looks like silo uses only the HDF5 API to detect the compression (src/hdf5_drv/silo_hdf5.c, lines 3112 and following), so the dependency on szip can go away.
I'll attach a new patch.
comment:6 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | kurtjaeke@… removed |
|---|---|
| Keywords: | haspatch added |
| Owner: | changed from macports-tickets@… to ryandesign@… |
| Status: | new → assigned |
comment:7 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
silo Portfile patch to upgrade to 4.9.