Opened 7 years ago

Closed 7 years ago

#38343 closed submission (fixed)

New port 'xrootd'

Reported by: cjones051073 (Chris Jones) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.1.3
Keywords: Cc:
Port: xrootd

Description

Please find attached the Portfile for a new port submission, for xrootd. See

http://xrootd.slac.stanford.edu

for details on the port.

It will be useful for the ROOT port, as if admitted will allow a new xrootd variant (patch will be submitted soon after this).

I am not 100% sure of the best category. I think science is the best fit, but am open to alternatives ;)

Chris

Attachments (2)

Portfile (2.4 KB) - added by cjones051073 (Chris Jones) 7 years ago.
man.patch (452 bytes) - added by cjones051073 (Chris Jones) 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by ryandesign (Ryan Schmidt)

Thanks. Some comments:

  • The lines "distname ${name}-${version}" and "worksrcdir ${name}-${version}" should be deleted; those are the default
  • "-DCMAKE_BUILD_TYPE=Release" doesn't need to be appended to configure.args; the cmake portgroup does that for you
  • In the perl variant, swig-perl should most likely be a build dependency, not a library dependency

comment:2 Changed 7 years ago by cjones051073 (Chris Jones)

Thanks for the (amazingly) fast response ...

I've fixed this in my local copy, but I just noticed the messages

--->  Staging xrootd into destroot
Warning: violation by /opt/local/man
Warning: xrootd violates the layout of the ports-filesystems!
Warning: Please fix or indicate this misbehavior (if it is intended), it will be an error in future releases!
--->  Installing xrootd @3.2.7_0+kerberos+perl+readline+ssl
--->  Activating xrootd @3.2.7_0+kerberos+perl+readline+ssl

Not sure how I missed them before, but I should fix them I guess.... Any pointers on what they actually mean ?

cheers Chris

comment:3 Changed 7 years ago by cjones051073 (Chris Jones)

OK, I've fixed the problem with the filesystem violation. It turns out the man path is partly hardcoded in the cmake files, and its not possible to fix without the patch file I will attach, with a new Portfile. This should address the warning, and the issues outlined above in comment:1

cheers Chris

Last edited 7 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

Changed 7 years ago by cjones051073 (Chris Jones)

Attachment: Portfile added

Changed 7 years ago by cjones051073 (Chris Jones)

Attachment: man.patch added

comment:4 Changed 7 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

Thanks.

comment:5 Changed 7 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Committed in r103901 with these changes:

  • changed master_sites to re-use homepage variable
  • renamed the patchfile
  • removed configure.arg "-DCMAKE_INSTALL_MANDIR="share/man"" because the build system ignores that and sets it itself; the patch takes care of fixing this
  • removed configure.arg "-DCMAKE_BUILD_TYPE=Release" because the cmake portgroup does that for you
  • removed "destroot.dir ${workpath}/build" because the default destroot.dir is build.dir
  • added long_description (see "port lint"); shortened description
Note: See TracTickets for help on using tickets.