Opened 11 years ago
Closed 10 years ago
#38356 closed update (wontfix)
gmock: update to 1.6.0
| Reported by: | ryandesign (Ryan Carsten Schmidt) | Owned by: | josephholsten@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.3 |
| Keywords: | haspatch | Cc: | kibodmitry@…, cooljeanius (Eric Gallager) |
| Port: | gmock |
Description
gmock 1.6.0 is available; the port should probably be updated.
Here is a patch. It fails at destroot with this message:
'make install' is dangerous and not supported. Instead, see README for how to integrate Google Test into your build system.
So somebody will have to figure out what this means and how to fix this.
Attachments (1)
Change History (9)
Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
| Attachment: | gmock-1.6.0.diff added |
|---|
comment:1 Changed 11 years ago by cooljeanius (Eric Gallager)
comment:2 Changed 11 years ago by larryv (Lawrence Velázquez)
If installing system-wide is not supported by upstream, is it wise for us to encourage it?
comment:3 follow-ups: 4 8 Changed 11 years ago by ryandesign (Ryan Carsten Schmidt)
I was going to point out all the ports that depend on gmock... but then realized it's just amarok, because I just added it, and then discovered there's a way to turn off its use. So maybe that's what we should do for amarok, and delete the port.
comment:4 follow-up: 5 Changed 11 years ago by larryv (Lawrence Velázquez)
Replying to ryandesign@…:
I was going to point out all the ports that depend on gmock... but then realized it's just amarok, because I just added it, and then discovered there's a way to turn off its use. So maybe that's what we should do for amarok, and delete the port.
This would be best, I think.
comment:5 Changed 10 years ago by jmgant@…
Replying to larryv@…:
Replying to ryandesign@…:
I was going to point out all the ports that depend on gmock... but then realized it's just amarok, because I just added it, and then discovered there's a way to turn off its use. So maybe that's what we should do for amarok, and delete the port.
This would be best, I think.
Is there a way to install Amarok without it? I am fairly green as far as my OSX skills are concerned. I am getting errors about gmock when attempting to install Amarok.
comment:6 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | kibodmitry@… added |
|---|
Has duplicate #42260 which notes the gmock build failure under Mavericks.
comment:8 Changed 10 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Replying to ryandesign@…:
I was going to point out all the ports that depend on gmock... but then realized it's just amarok, because I just added it, and then discovered there's a way to turn off its use. So maybe that's what we should do for amarok,
and delete the port.
Homebrew interprets this as follows in its blacklist:
Installing gmock system-wide is not recommended; it should be vendored in your projects that use it.(https://github.com/mxcl/homebrew/blob/master/Library/Homebrew/blacklist.rb#L46)
However, I'm not convinced that this is the correct approach. I would like to continue installing gmock system-wide anyway whether it's recommended or not. If that's not possible though, at least put it all in some subdirectory of
${prefix}/shareor something for easy copying to one's own projects.